Fix fluid name on tank GUI depending on server locale#1915
Merged
serenibyss merged 1 commit intoGregTechCEu:masterfrom Jul 10, 2023
Merged
Fix fluid name on tank GUI depending on server locale#1915serenibyss merged 1 commit intoGregTechCEu:masterfrom
serenibyss merged 1 commit intoGregTechCEu:masterfrom
Conversation
serenibyss
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Currently having different locale setting on client and server makes client render fluid name on some tank GUIs with server locale. This PR fixes that.
Implementation Details
Currently
getFluidNameTextsyncs already translated text. I changed them to send unlocalized name withTextComponentTranslation, so that client can translate text with its own locale setting.Outcome
Fix bug.