Skip to content

Comments

Improve ghost circuit slot#1954

Merged
serenibyss merged 1 commit intomasterfrom
sb-ghost-circuit-improved
Jul 15, 2023
Merged

Improve ghost circuit slot#1954
serenibyss merged 1 commit intomasterfrom
sb-ghost-circuit-improved

Conversation

@serenibyss
Copy link
Member

@serenibyss serenibyss commented Jul 14, 2023

  • Removes +/- buttons
  • Scroll wheel to increment/decrement
  • Left click to increment, right click to decrement
  • Shift right click to clear
  • Incrementing/decrementing now wraps to the opposite side
  • Circuit 0 is now excluded
  • Scroll wheel can now "create" the circuit instead of needing a click

To do:

  • Shift left click to pull up a circuit picker screen with all 32 options available

@serenibyss serenibyss added the type: feature New feature or request label Jul 14, 2023
@serenibyss serenibyss requested a review from a team as a code owner July 14, 2023 21:03
ghzdude
ghzdude approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@ghzdude ghzdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@serenibyss serenibyss merged commit 232e4fa into master Jul 15, 2023
@serenibyss serenibyss deleted the sb-ghost-circuit-improved branch July 15, 2023 00:28
MrKono added a commit to MrKono/GregTech that referenced this pull request Jul 15, 2023
@MrKono
[apply] GregTechCEu#1954 / [update] version
c452887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghzdude ghzdude ghzdude approved these changes

Assignees

No one assigned

Labels

type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serenibyss @ghzdude