Make recipe check command also check for recipes with empty inputs#1980
Merged
serenibyss merged 2 commits intoGregTechCEu:masterfrom Jul 23, 2023
Merged
Make recipe check command also check for recipes with empty inputs#1980serenibyss merged 2 commits intoGregTechCEu:masterfrom
serenibyss merged 2 commits intoGregTechCEu:masterfrom
Conversation
serenibyss
reviewed
Jul 23, 2023
serenibyss
approved these changes
Jul 23, 2023
MrKono
added a commit
to MrKono/GregTech
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds some more checks to
/gt recipecheckOutcome
Now tests for empty input items and makes a list of all empty oredicts that were found. Also cleaned up some output formatting, made the rest of the
prettyPrint*methods static, and fixed some warnings.Additional Information
Since empty oredicts are only added if a recipe with an empty input is found, the handling for those only runs if there are recipes with empty inputs.
Example output
Potential Compatibility Issues
Command is now referred to as "recipe issue check", since it's not just for recipe conflicts anymore, translations may need to be updated