Skip to content

Comments

Make recipe check command also check for recipes with empty inputs#1980

Merged
serenibyss merged 2 commits intoGregTechCEu:masterfrom
kumquat-ir:more-recipe-checking
Jul 23, 2023
Merged

Make recipe check command also check for recipes with empty inputs#1980
serenibyss merged 2 commits intoGregTechCEu:masterfrom
kumquat-ir:more-recipe-checking

Conversation

@kumquat-ir
Copy link
Contributor

What

Adds some more checks to /gt recipecheck

Outcome

Now tests for empty input items and makes a list of all empty oredicts that were found. Also cleaned up some output formatting, made the rest of the prettyPrint* methods static, and fixed some warnings.

Additional Information

Since empty oredicts are only added if a recipe with an empty input is found, the handling for those only runs if there are recipes with empty inputs.

Example output

[14:27:22] [Server thread/INFO] [GregTech]: No recipe conflicts found in all recipe maps!
[14:27:22] [Server thread/INFO] [GregTech]: [Recipe Checker] Found 6 recipes with empty inputs
[14:27:22] [Server thread/ERROR] [GregTech]: 
[In Recipe map] : "extruder"
[14:27:22] [Server thread/ERROR] [GregTech]: 
EU/t: 42, Duration: 588
Item inputs:
    (OreDict: "ingotWood") {  } * 6
     {  (MetaItem) shape.extruder.pipe.large * 1 } * 1
Item outputs:
    (MetaBlock) pipeLargeFluidWood * 1

[14:27:22] [Server thread/ERROR] [GregTech]: 
EU/t: 42, Duration: 588
Item inputs:
    (OreDict: "ingotTreatedWood") {  } * 6
     {  (MetaItem) shape.extruder.pipe.large * 1 } * 1
Item outputs:
    (MetaBlock) pipeLargeFluidTreatedWood * 1

[14:27:22] [Server thread/ERROR] [GregTech]: 
EU/t: 42, Duration: 294
Item inputs:
    (OreDict: "ingotTreatedWood") {  } * 3
     {  (MetaItem) shape.extruder.pipe.normal * 1 } * 1
Item outputs:
    (MetaBlock) pipeNormalFluidTreatedWood * 1

[14:27:22] [Server thread/ERROR] [GregTech]: 
EU/t: 42, Duration: 98
Item inputs:
    (OreDict: "ingotWood") {  } * 1
     {  (MetaItem) shape.extruder.pipe.small * 1 } * 1
Item outputs:
    (MetaBlock) pipeSmallFluidWood * 1

[14:27:22] [Server thread/ERROR] [GregTech]: 
EU/t: 42, Duration: 294
Item inputs:
    (OreDict: "ingotWood") {  } * 3
     {  (MetaItem) shape.extruder.pipe.normal * 1 } * 1
Item outputs:
    (MetaBlock) pipeNormalFluidWood * 1

[14:27:22] [Server thread/ERROR] [GregTech]: 
EU/t: 42, Duration: 98
Item inputs:
    (OreDict: "ingotTreatedWood") {  } * 1
     {  (MetaItem) shape.extruder.pipe.small * 1 } * 1
Item outputs:
    (MetaBlock) pipeSmallFluidTreatedWood * 1

[14:27:22] [Server thread/INFO] [GregTech]: [Recipe Checker] Found 2 empty oredicts
[14:27:22] [Server thread/ERROR] [GregTech]: 
ingotTreatedWood
ingotWood
[14:27:22] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] No recipe conflicts found!
[14:27:22] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Recipe check found 6 recipes with empty inputs and 2 empty oredicts. Check the server log for more info

Potential Compatibility Issues

Command is now referred to as "recipe issue check", since it's not just for recipe conflicts anymore, translations may need to be updated

@kumquat-ir kumquat-ir requested a review from a team as a code owner July 22, 2023 18:37
@ALongStringOfNumbers ALongStringOfNumbers added the type: feature New feature or request label Jul 22, 2023
@serenibyss serenibyss merged commit 490daf5 into GregTechCEu:master Jul 23, 2023
MrKono added a commit to MrKono/GregTech that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants