Fix some failing tests and switch to more general method#199
Merged
TechLord22 merged 1 commit intomasterfrom Oct 24, 2021
Merged
Fix some failing tests and switch to more general method#199TechLord22 merged 1 commit intomasterfrom
TechLord22 merged 1 commit intomasterfrom
Conversation
TechLord22
approved these changes
Oct 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR fixes some tests failing, and switches to the more general
hasMaintenanceProblems()instead of checking the config directly.The tests were failing because the initialization of the MTE in the tests overrode
hasMaintenanceProblems(), but the checks in code were directly checking the config instead of the method.Outcome:
Fixes some tests