Skip to content

Comments

Improve super tank fluid sync#2017

Merged
serenibyss merged 1 commit intomasterfrom
sb-fix-tank-sync
Jul 31, 2023
Merged

Improve super tank fluid sync#2017
serenibyss merged 1 commit intomasterfrom
sb-fix-tank-sync

Conversation

@serenibyss
Copy link
Member

@serenibyss serenibyss commented Jul 30, 2023

Improves super tank fluid sync in two ways:

  • No longer sends a packet with null fluid stack each tick while empty
  • Only sends a packet with an int instead of a serialized NBT fluidstack when the amount changes

@serenibyss serenibyss added the type: refactor Suggestion to refactor a section of code label Jul 30, 2023
@serenibyss serenibyss requested a review from a team as a code owner July 30, 2023 07:20
@serenibyss serenibyss merged commit ae7636c into master Jul 31, 2023
@serenibyss serenibyss deleted the sb-fix-tank-sync branch July 31, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TechLord22 TechLord22 TechLord22 approved these changes

Assignees

No one assigned

Labels

type: refactor Suggestion to refactor a section of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serenibyss @TechLord22