Conversation
ALongStringOfNumbers
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#1638 introduced a bug where only crafting recipes can be applied in the recipe chart. That PR was supposed to fix #1595.
That bug happened because of
0.0f / 0.0f = infinitycausing a int overflow which causes the item to be empty.This pr fixes that by never dividing by anything less than 1. I also added a blacklist to jei to prevent certain jei categories to be applied to the recipe chart (like material tree or JEI info page).
I also cleaned the code a little bit up in
RGNode.Implementation Details
Terminal magic
Outcome
Undo #1638 and fix #1595 properly.
Closes #2007
Additional Information
No
Potential Compatibility Issues
Probably none