Skip to content

Comments

Fix TextFieldWidget2 not focusing the gui#2064

Merged
TechLord22 merged 1 commit intomasterfrom
br-gui-focus-fix
Sep 2, 2023
Merged

Fix TextFieldWidget2 not focusing the gui#2064
TechLord22 merged 1 commit intomasterfrom
br-gui-focus-fix

Conversation

@brachy84
Copy link
Contributor

@brachy84 brachy84 commented Sep 1, 2023

What

In order for other mods to not trigger keybinds in gui, one must call GuiScreen#setFocused(). That was not being done in TextFieldWidget2.

Outcome

Closes #2063

Additional Information

Not tested, but i assume it works.
This is a temporary fix as ModularUI also fixes this issue.

Potential Compatibility Issues

None

@brachy84 brachy84 requested a review from a team as a code owner September 1, 2023 09:53
@brachy84 brachy84 added the type: bug Something isn't working label Sep 1, 2023
Copy link
Member

@bruberu bruberu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with these changes seems to show that it's properly fixed; I can type on the clipboard without opening a config screen.

@TechLord22 TechLord22 merged commit 1dca073 into master Sep 2, 2023
@TechLord22 TechLord22 deleted the br-gui-focus-fix branch September 2, 2023 15:42
ghzdude pushed a commit to ghzdude/GregTechCEu that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clipboard doesn't block hotkeys

3 participants