Skip to content

Comments

Cleanup and fix loot table injection#2075

Merged
TechLord22 merged 2 commits intomasterfrom
tc-loottable-fix
Sep 17, 2023
Merged

Cleanup and fix loot table injection#2075
TechLord22 merged 2 commits intomasterfrom
tc-loottable-fix

Conversation

@TechLord22
Copy link
Member

What

Cleans up and fixes issues with loot table injection.

Due to an insufficient generated name for loot entries, entries would often be marked as duplicate and would not be added. This PR fixes this by incorporating all relevant values in the unique name.

Some examples of when this would previously fail:

  1. The same item injected to the same loot table twice, but with different weights and/or quantities.
  2. The same item injected into the same loot table twice, but once with an NBT Tag and another time without.

This PR also improves logging for failed loot table injections to allow easier debugging in the future.

Outcome

Cleans up and fixes failed loot table injections.

Potential Compatibility Issues

No compatibility issues are expected. Nothing publicly-facing has changed on a method signature or class level.

@TechLord22 TechLord22 added the type: bug Something isn't working label Sep 9, 2023
@TechLord22 TechLord22 requested a review from a team as a code owner September 9, 2023 19:04
@TechLord22 TechLord22 added type: bug Something isn't working and removed type: bug Something isn't working labels Sep 9, 2023
@TechLord22 TechLord22 merged commit 522f392 into master Sep 17, 2023
@TechLord22 TechLord22 deleted the tc-loottable-fix branch September 17, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants