Cleanup and fix loot table injection#2075
Merged
TechLord22 merged 2 commits intomasterfrom Sep 17, 2023
Merged
Conversation
ALongStringOfNumbers
approved these changes
Sep 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cleans up and fixes issues with loot table injection.
Due to an insufficient generated name for loot entries, entries would often be marked as duplicate and would not be added. This PR fixes this by incorporating all relevant values in the unique name.
Some examples of when this would previously fail:
This PR also improves logging for failed loot table injections to allow easier debugging in the future.
Outcome
Cleans up and fixes failed loot table injections.
Potential Compatibility Issues
No compatibility issues are expected. Nothing publicly-facing has changed on a method signature or class level.