Add Advancements and New Crafting Station#26
Merged
TechLord22 merged 5 commits intomasterfrom Jul 10, 2021
Merged
Conversation
serenibyss
reviewed
Jul 10, 2021
Member
serenibyss
left a comment
serenibyss
left a comment
There was a problem hiding this comment.
Other than 1 comment, the only thing I really have to add to this is that I think we should have an advancement for the LCR. Also, that I think it would make more sense for the Steam Age advancement tab to unlock with a Copper Ingot rather than a Log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds advancements marking progression from Steam to UV. I do not know how (at this time) to add some of the other more unique advancements, such as one for machine explosions and other unique GT features, but these should serve as a solid baseline for some loose-ish guided progression. There are a total of 89 advancements added.
For testing/viewing these in-game, tabs only show up when you unlock an advancement from the tab they belong to (MC behavior). You can circumvent this by running the following command:
/advancement grant @p everything.The crafting station has also been changed to be wooden, and more useful earlier on.