Prevent Recipe Properties from Overlapping in JEI#266
Merged
TechLord22 merged 3 commits intomasterfrom Dec 3, 2021
Merged
Conversation
BraggestSage833
approved these changes
Nov 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR prevents recipes with properties from overlapping with the recipe display. Previously, 4 or more columns of inputs, and/or sometimes outputs, would have property text on top of slot widgets. This PR resolves this. It also allows the
groupOutputto be applied to inputs for any purpose. This PR no longer offsets the recipe display for group output, as it was unneeded.How solved:
The size of the JEI page for the recipemap is lengthened based on the number of properties it has, while leaving the recipe itself in the same location at the top of the page.
Outcome:
Prevents Recipe Properties from overlapping in JEI.
Additional info:
An example of the PR working. Without the changes made in this PR, the temperature property's shifting of the total energy amount would have overlapped with the fluid input slots.
Possible compatibility issue:
Currently it goes off of the first recipe's properties of a given RecipeMap, as there was no other way to determine the amount of expected properties. This could result in some recipes with properties not being correctly caught.