Fix Negative EUt in TOP #2666
Merged
Fix Negative EUt in TOP #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix check for energy prod line
remove redundant methods
serenibyss
approved these changes
Feb 3, 2025
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fixes eut being negative sometimes in recipe logic, making TOP give the wrong value
Implementation Details
add method
getEnergyContainer()to ARL and simplify extending classeseut should ONLY be negative in
drawEnergy()in ARLi feel like boilers and steam recipe logic could use an IEnergyContainer to wrap their logic and further simplify them
Outcome
TOP is correct