Make research EU/t long to be consistent with recipes using long #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zorbatron
reviewed
Feb 13, 2025
Member
Zorbatron
left a comment
Zorbatron
left a comment
There was a problem hiding this comment.
Should CWU/t be long aswell?
Contributor
Author
|
Maybe? Though if we go by regular tier scaling by assuming ZPM starts with 32 CWU/t and multiply by 4 for each, you end up with MAX + 6 before reaching the limit (not thinking about total CWU though), even more if the scaling decides to use powers of 2 instead of 4. I think int is reasonable. |
Member
|
Makes sense. |
Zorbatron
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes EU/t from int to long for research.
Implementation Details
int to long
Outcome
use numbers bigger than int max, consistent with general recipes
Potential Compatibility Issues
might have missed something