Un-hardcode toolbelt localization #2727
Merged
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-W-K
added
type: refactor
kumquat-ir
approved these changes
Feb 16, 2025
MrKono
added a commit
to GTModpackTeam/GregTech
that referenced
this pull request
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Splits the toolbelt name localization key into two localization keys, one for when no tool is selected and one for when a tool is selected and displayed in the name. This replaces the previous implementation that hardcoded the addition of parenthesis, so that other languages can tweak the exact syntax of the localization as necessary.
Outcome
No translation problems down the line (hopefully!)