Conversation
TechLord22
force-pushed
the
locking
branch
3 times, most recently
from
43a62e5 to
f380783
Compare
Member
|
Stealing this PR to improve it a bit and add more features |
Refactor `MetaTileEntityDrum` slightly
Member
|
Changes since my commits:
|
serenibyss
added
status: high priority
Member
|
Changing this to |
TechLord22
commented
Dec 8, 2021
| @Override | ||
| public void handleClientAction(int id, PacketBuffer buf) { | ||
| super.handleClientAction(id, buf); | ||
| if (id == 12) { |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| } else { | ||
| phantomTank.setFluid(null); | ||
| } | ||
| } else if (id == 13) { |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| @Override | ||
| public boolean mouseClicked(int mouseX, int mouseY, int button) { | ||
| if (isMouseOverElement(mouseX, mouseY)) { | ||
| writeClientAction(12, buf -> {}); |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| FluidStack stack = phantomTank.getFluid(); | ||
| if (stack == null && lastPhantomStack != null) { | ||
| lastPhantomStack = null; | ||
| writeUpdateInfo(10, buf -> {}); |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| if (!stack.isFluidEqual(lastPhantomStack)) { | ||
| lastPhantomStack = stack.copy(); | ||
| NBTTagCompound stackTag = stack.writeToNBT(new NBTTagCompound()); | ||
| writeUpdateInfo(11, buf -> buf.writeCompoundTag(stackTag)); |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| writeUpdateInfo(11, buf -> buf.writeCompoundTag(stackTag)); | ||
| } else if (stack.amount != 0) { | ||
| lastPhantomStack.amount = 0; | ||
| writeUpdateInfo(12, buf -> {}); |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| @Override | ||
| public void readUpdateInfo(int id, PacketBuffer buf) { | ||
| super.readUpdateInfo(id, buf); | ||
| if (id == 10) { |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| super.readUpdateInfo(id, buf); | ||
| if (id == 10) { | ||
| lastPhantomStack = null; | ||
| } else if (id == 11) { |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
| return; | ||
| } | ||
| lastPhantomStack = FluidStack.loadFluidStackFromNBT(stackTag); | ||
| } else if (id == 12) { |
Member
Author
There was a problem hiding this comment.
Should put this value in GregtechDataCodes.
bruberu
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.