Fix ClassNotFound exceptions on servers due to client only class being accessed in cover code #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvers (client only class being accessed)
Contributor
|
On this branch, I cannot runClient or runServer at all, they both crash with another ClassNotFound for |
Member
Author
|
Where in loading does it crash, and you provide the entire stack trace? Client and server both work for me. |
ghzdude
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes
ClassNotFoundexceptions due toLangKey#getbeing inside aDynamicKeystring supplier.DynamicKey's constructor gets the string from the supplier to null check, but this ends up getting the result of theLangKeywhich hasClientScreenHandler.getTicks()in theget()method, which is annotated withSideOnly(CLIENT).Implementation Details
Remove usage of dynamic keys in the ender cover code and change
BaseFilterContainer#getFilterNametogetFilterKeyso a lang key can be returned directely.Outcome
You can use covers on servers.
Additional Information
This affected conveyor and robot arm covers too