Skip to content

Fix clipboard always rendered at full brightness #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zorbatron merged 1 commit into from
Aug 7, 2025
Merged

Fix clipboard always rendered at full brightness #2845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/main/java/gregtech/client/renderer/texture/custom/ClipboardRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import net.minecraft.client.renderer.texture.TextureMap;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
Expand Down Expand Up @@ -74,7 +75,8 @@ public static void renderBoard(CCRenderState renderState, Matrix4 translation, I
translation.translate(0.5, 0.5, 0.5);
translation.rotate(Math.toRadians(90.0 * rotations.indexOf(rotation)), Rotation.axes[1]);
translation.translate(-0.5, -0.5, -0.5);

World world = clipboard.getWorld();
if (world != null) renderState.setBrightness(world, clipboard.getPos());
// Render Clipboard
for (EnumFacing renderSide : EnumFacing.VALUES) {
boxTextureMap.forEach((box, sprite) -> Textures.renderFace(renderState, translation, pipeline, renderSide,
Expand All @@ -89,7 +91,17 @@ public static void renderGUI(double x, double y, double z, EnumFacing rotation,
GlStateManager.pushMatrix();
float lastBrightnessX = OpenGlHelper.lastBrightnessX;
float lastBrightnessY = OpenGlHelper.lastBrightnessY;
OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, 240.0F, 240.0F);

float lx = 240, ly = 240;
World world = clipboard.getWorld();
if (world != null) {
int light = world.getCombinedLight(clipboard.getPos(), 0);

lx = (float) light % 0x10000;
ly = (float) light / 0x10000;
}

OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, lx, ly);
RenderHelper.disableStandardItemLighting();

// All of these are done in reverse order, by the way, if you're reviewing this :P
Expand Down
Loading