Fix an empty tooltip on GT fluid slots that have no fluid #2863
+52
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zorbatron
added
type: bug
| if (a == b) return true; | ||
| if (a == null) return false; | ||
| return a.isFluidEqual(b); | ||
| } |
Contributor
There was a problem hiding this comment.
Why make this when it is covered by FluidStack#isFluidEqual()?
Member
Author
There was a problem hiding this comment.
Because it replaces if (init || current == null || lastFluid == null || current.isFluidEqual(lastFluid)) { so it works when both stacks are null.
ALongStringOfNumbers
approved these changes
Sep 15, 2025
ALongStringOfNumbers
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In #2672, I accidentally made it so if a GT fluid slot had no fluid, it would insert an empty key into the tooltip instead of doing nothing which made it so empty slots would have a small black dot near the cursor.
Additionally makes it so these only happen when the fluid actually changes: