Fix Crafting Station Partial Dupe Bug #2885
Merged
+55
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
added
type: bug
ghzdude
force-pushed
the
gh/fix-crafting-station-again
branch
from
efe0341 to
81929bd
Compare
M-W-K
approved these changes
Nov 12, 2025
Contributor
M-W-K
left a comment
M-W-K
left a comment
There was a problem hiding this comment.
Can't wait for gh/fix-crafting-station-again-again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a partial dupe bug in the Crafting Station when shift clicking the output slot
Implementation Details
While adding
+ outputStack.getCount()in the while loop would be a simple fix to the above issue, it also revealed an issues inCraftingRecipeLogic#performRecipe().All of the input slot update code is in it's own method now
While I was doing a pass over everything, I spotted small areas of improvement.
(sure hope it doesn't result in bugs :clueless:)
Outcome
Crafting Station dupe allegations can finally be over... maybe
Additional Information
The Crafting Station is Fixed. The Crafting Station is Fixed. The Crafting Station is Fixed. The Crafting Station is Fixed.