Allow quantum tanks/chest + super tanks/chest to auto export and migrate Dan’s quantum tanks/chest PR#30
Merged
serenibyss merged 17 commits intoGregTechCEu:masterfrom Jul 15, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Allows quantum tanks/chest + super tanks/chest to auto export.
Also migrates Dan’s PR for Quantum tanks
How solved:
I implemented IActiveOutputSide to both quantum tanks/chests with necessary methods and NBT
Outcome:
Allows faster exporting of items/fluids and Dan's PR allow quantum tanks/chest to maintain inventory after broken
Additional info:
In an effort to not break the handlers I have allowed items/fluids to always enter the output side. As well I have prevented covers from being placed on the output side. Also includes small MetaTileEntities error.
Possible compatibility issue:
Previously placed tanks/chest may break due to changing implementation
Co-authored-by: DStrand1 DStrand1@users.noreply.github.com