Merged
Conversation
serenibyss
force-pushed
the
net-rewrite
branch
from
b6f6702 to
d9b4ce5
Compare
TechLord22
approved these changes
Dec 10, 2021
Rongmario
approved these changes
Dec 10, 2021
Contributor
Rongmario
left a comment
Rongmario
left a comment
There was a problem hiding this comment.
Looks fine, some packets are a bit :concern: but at least its all on the new and cleaner packet system.
| @NoArgsConstructor | ||
| public class PacketUIOpen implements IPacket { | ||
|
|
||
| private int uiFactoryId; |
Contributor
There was a problem hiding this comment.
This can be a short. Since the registry only allows Short.MAX_VALUE!
serenibyss
force-pushed
the
net-rewrite
branch
from
d9b4ce5 to
81b980d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite
NetworkHandlerand surrounding classes to have a consistent networking API and cleanup a lot of bad code