Merged
Conversation
serenibyss
reviewed
Jul 15, 2021
Member
serenibyss
left a comment
serenibyss
left a comment
There was a problem hiding this comment.
I think this logic LGTM. One comment (other than the possible performance increase): we should be on the lookout for other materials that are handled manually currently/could use decomp recipes to utilize this code more
serenibyss
requested changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds division for decomposition recipes. There are very few divisible recipes in GTCE, but Realgar and Phosphorus Pentoxide are good ones to check. The duration is divided accordingly. Fluid input decomposition recipes are not reduced, as they all go off of 1000mB input amounts.