Make StoneTypes not drop custom items#335
Merged
serenibyss merged 4 commits intomasterfrom Dec 13, 2021
Merged
Conversation
ALongStringOfNumbers
approved these changes
Dec 12, 2021
Contributor
ALongStringOfNumbers
left a comment
ALongStringOfNumbers
left a comment
There was a problem hiding this comment.
This looks good to me implementation wise, but could use testing across other mods.
I tested with our block breaker, mining hammers, and tnt and it all worked there.
I tried testing with the Little Hammer from Little Tiles, but apparently you cannot use the Little Hammer on our ores (something to look into)
Syrcan
added a commit
to Syrcan/GregTech
that referenced
this pull request
Dec 14, 2021
This reverts commit 6ce89cb.
Syrcan
pushed a commit
to Syrcan/GregTech
that referenced
this pull request
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, StoneTypes other than Stone, Netherrack, and Endstone should be impossible to obtain. As a result, they have been hidden from CreativeTabs and JEI, have no OreDictionary entries, and have no recipes. If it is ever possible to obtain one of these ores, that issue should be addressed instead of readding any of this.