Skip to content

Crafting station fixes#368

Merged
bruberu merged 11 commits intomasterfrom
craftingStationFixes
Dec 21, 2021
Merged

Crafting station fixes#368
bruberu merged 11 commits intomasterfrom
craftingStationFixes

Conversation

@bruberu
Copy link
Copy Markdown
Member

@bruberu bruberu commented Dec 18, 2021

Fixes several issues in the crafting station, including:

  • Highlighting not working at all
  • Memory not working at all
  • Tools in the GUI being damaged
  • Sounds not being played from tools in the crafting station

@bruberu bruberu marked this pull request as draft December 18, 2021 19:39
@bruberu
Copy link
Copy Markdown
Member Author

bruberu commented Dec 18, 2021

There is still one issue with tool cycling that I have not fixed yet, although it has to do with cycling occurring within ItemSourceLists, as tools are continually deleted. This will require tools to be sorted based on durability.

@ALongStringOfNumbers ALongStringOfNumbers added the status: high priority Issue or PR should be prioritized for reviews label Dec 19, 2021
@bruberu bruberu marked this pull request as ready for review December 20, 2021 03:52
@bruberu
Copy link
Copy Markdown
Member Author

bruberu commented Dec 20, 2021

Given that the tool cycling bug seems to be an extremely difficult bug to fix, and that it's fairly minor overall, it will not be fixed in this PR.

Comment thread src/main/java/gregtech/api/items/toolitem/IToolStats.java Outdated
Copy link
Copy Markdown
Contributor

@ALongStringOfNumbers ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering is a bit weird on stairs when looking in the stored items view:
2021-12-20_16-58

Maybe something to ask kila about if he has time, but it is pretty minor

When hovering over a recipe in MemorizedRecipeWidget, it should have additional tooltip information on how to lock a recipe, and how to populate the crafting grid with a recipe.

@bruberu bruberu force-pushed the craftingStationFixes branch from c389e80 to ea99ec1 Compare December 21, 2021 02:10
@bruberu bruberu merged commit 3690045 into master Dec 21, 2021
@bruberu bruberu deleted the craftingStationFixes branch December 21, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: high priority Issue or PR should be prioritized for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants