-
Notifications
You must be signed in to change notification settings - Fork 449
refactor: improve performance for Jaeger APIs #5766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/api/services performance by adding the trace services table
/api/services performance by adding the trace services tablec166fc2 to
e04b551
Compare
|
While creating the service table, we can put a comment in the origin trace table, so that we can automatically switch to using the service table for the But that can be another PR. 🚀 |
033d08e to
ac8ec39
Compare
shuiyisong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
src/servers/src/http/extractor.rs
Outdated
| )?, | ||
| trace_services_table_name: string_value_from_header( | ||
| headers, | ||
| &[GREPTIME_TRACE_SERVICES_TABLE_NAME_HEADER_NAME], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to think about this again. This means when user needs to use a custom table name for traces, it has specify two tables names. And this will also expose the services table from an implementation to an API because user has to understand it and provide a correct name on ingestion and query.
I would suggest to use a pattern to generate service table from user-provided trace table name, for example, append a fixed suffix _services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds reasonable.
2d9d944 to
7420d06
Compare
7420d06 to
cf1eda2
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add the dimension table
greptime_trace_servicesto record all theservice_name. It may be a workaround solution, but it is effective in a large trace table;Expand the default limit from
100to2000;PR Checklist
Please convert it to a draft if some of the following conditions are not met.