Skip to content

Conversation

@zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Mar 25, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Add the dimension table greptime_trace_services to record all the service_name. It may be a workaround solution, but it is effective in a large trace table;

  2. Expand the default limit from 100 to 2000;

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zyy17 zyy17 changed the title refactor: improve jaeger '/api/services' performance by adding the trace services table refactor: improve jaeger /api/services performance by adding the trace services table Mar 25, 2025
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 25, 2025
@zyy17 zyy17 marked this pull request as ready for review March 25, 2025 08:33
@zyy17 zyy17 requested a review from a team as a code owner March 25, 2025 08:33
@zyy17 zyy17 changed the title refactor: improve jaeger /api/services performance by adding the trace services table refactor: improve performance for Jaeger APIs Mar 25, 2025
@zyy17 zyy17 requested review from evenyag, paomian, shuiyisong and sunng87 and removed request for a team March 25, 2025 09:20
@zyy17 zyy17 force-pushed the refactor/add-traces-services-table branch 2 times, most recently from c166fc2 to e04b551 Compare March 25, 2025 14:01
@shuiyisong
Copy link
Contributor

While creating the service table, we can put a comment in the origin trace table, so that we can automatically switch to using the service table for the /services API.

But that can be another PR. 🚀

@zyy17 zyy17 force-pushed the refactor/add-traces-services-table branch from 033d08e to ac8ec39 Compare April 3, 2025 04:51
@zyy17 zyy17 requested a review from sunng87 April 3, 2025 04:56
Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

)?,
trace_services_table_name: string_value_from_header(
headers,
&[GREPTIME_TRACE_SERVICES_TABLE_NAME_HEADER_NAME],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to think about this again. This means when user needs to use a custom table name for traces, it has specify two tables names. And this will also expose the services table from an implementation to an API because user has to understand it and provide a correct name on ingestion and query.

I would suggest to use a pattern to generate service table from user-provided trace table name, for example, append a fixed suffix _services

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable.

@zyy17 zyy17 force-pushed the refactor/add-traces-services-table branch from 2d9d944 to 7420d06 Compare April 7, 2025 14:15
@zyy17 zyy17 closed this Apr 7, 2025
@zyy17 zyy17 force-pushed the refactor/add-traces-services-table branch from 7420d06 to cf1eda2 Compare April 7, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants