feat(seeding): range + combine seeding rules (foundation for real multi-main)#323
Merged
Conversation
…ti-main)
Two new SeedingRule variants, the engine gap for composing the real MultiGP multi-main (per-main
brackets wired bottom-up):
- FromRankingRange { source_rounds, skip, take } — a SLICE of the merged best-per-pilot ranking
(e.g. C-main = qualifier seeds 13-20 = skip 12, take 8), not just top-N.
- Combine { sources } — union of sub-rules: resolve each, concat in order, dedupe keeping first
(e.g. B-main = Combine[range 7-12, FromRanking C-final top 2] = base seeds + bumped-up pilots).
round_field is refactored into a rule-level resolve_seeding that recurses for Combine. A depth guard
(MAX_SEEDING_DEPTH) is threaded through BOTH intra-Combine nesting AND the round_ranking/round_field
cross-round recursion, returning FillError::SeedingTooDeep (400) — this also closes a pre-existing
seeding-cycle stack-overflow risk (A seeds B, B seeds A). Validation rejects take=0, empty
Combine.sources, and over-deep nesting at add/update. Serde + bindings additive (legacy rules
unaffected); SeedingRule is now recursive.
cargo xtask ci green (no binding drift); frontend check 0 errors.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new
SeedingRulevariants — the engine gap for composing the real MultiGP multi-main:round_field→ recursiveresolve_seeding; a depth guard threaded through intra-Combine + the cross-roundround_ranking/round_fieldrecursion returnsSeedingTooDeep(400) — also closing a pre-existing seeding-cycle stack-overflow. Validation rejects take=0 / empty Combine / over-deep nesting. Serde + bindings additive; SeedingRule is now recursive.cargo xtask cigreen; frontend check 0 errors.🤖 Generated with Claude Code