Dnp3Adapters: Route log messages to the appropriate adapter#508
Merged
ritchiecarroll merged 1 commit intomasterfrom Mar 10, 2026
Merged
Dnp3Adapters: Route log messages to the appropriate adapter#508ritchiecarroll merged 1 commit intomasterfrom
ritchiecarroll merged 1 commit intomasterfrom
Conversation
ritchiecarroll
approved these changes
Mar 10, 2026
Member
ritchiecarroll
left a comment
ritchiecarroll
left a comment
There was a problem hiding this comment.
Couple minor optimizations are suggested. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses a lookup table to match the value of
LogEntry.aliasto theChannelIDof the appropriate DNP3 adapter. To associate theChannelIDwith the log entries, it must be passed as theidparameter when adding components to theIDNP3Managerinstance, such as when callingIDNP3Manager.AddTcpClient().You can see in the following screenshot that the
Application Pollmessages are being routed separately to each of the two adapters--DNPTEST1andDNPTEST2--in my test system.