GSF-17 Correct parsing logic for common expressions in TemplatedExpressionParser#521
Merged
ritchiecarroll merged 4 commits intomasterfrom Apr 29, 2026
Merged
GSF-17 Correct parsing logic for common expressions in TemplatedExpressionParser#521ritchiecarroll merged 4 commits intomasterfrom
ritchiecarroll merged 4 commits intomasterfrom
Conversation
ritchiecarroll
added a commit
that referenced
this pull request
Apr 29, 2026
Covers operator handling, nesting and sibling conditionals, reserved-symbol
escaping, eval{} integration, and the PR #521 regression case (eval{} indexer
inside a conditional result). Also exercises four real-world point-tag
templates from production adapter code.
ritchiecarroll
requested changes
Apr 29, 2026
Member
ritchiecarroll
left a comment
There was a problem hiding this comment.
Minor change requested.
Covers operator handling, nesting and sibling conditionals, reserved-symbol
escaping, eval{} integration, and the PR #521 regression case (eval{} indexer
inside a conditional result). Also exercises four real-world point-tag
templates from production adapter code.
ritchiecarroll
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a template with a common expression that has square brackets nested within it would not parse correctly.
I tested using the program below. Before the changes in this PR, I received the following error.
The expected result is
DAMP.MODE50.!.MAG.