fix[next][dace]: Make all node labels unique#2436
Merged
edopao merged 4 commits intoGridTools:mainfrom Jan 15, 2026
Merged
Conversation
Contributor
philip-paul-mueller
left a comment
There was a problem hiding this comment.
It looks good, I just have two comments here:
- I would add your check, that everything is unique as a check that is checked in an
assert. - You forgot to the nested SDFGs in your checks.
Contributor
Author
I've now also ensured that the nested SDFG labels are unique. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that some temporary scalars get unique name. The same fix was applied to the labels of nested SDFGs.
This should be the last source of duplicated labels. It was tested using this piece of code after the SDFG lowering: