Skip to content

ci: don't format uv.lock file#2513

Merged
egparedes merged 1 commit intoGridTools:mainfrom
romanc:romanc/pretty-toml-uv-lock
Mar 6, 2026
Merged

ci: don't format uv.lock file#2513
egparedes merged 1 commit intoGridTools:mainfrom
romanc:romanc/pretty-toml-uv-lock

Conversation

@romanc
Copy link
Copy Markdown
Contributor

@romanc romanc commented Mar 5, 2026

Description

The uv.lock file is auto-generated. It should not need formatting. Recent changes in identify, a dependency of pretty-format-toml added a rule to identify uv.lock as a toml file. Due to this change, the file got automatically picked up by the pre-commit worfklow for linting as a toml-file (which failes because it's not formatted as expected).

We only see this change on CI because for the pre-commit workflow, we don't pin exact versions of dependencies and thus always fetch the latest available. And with the automatic version update from 2.6.16 to 2.6.17 of identify, we get different results than locally (because there dependencies are pinned).

/cc @tehrengruber and @twicki since you both just updated the uv.lock file in your PRs.

Requirements

  • All fixes and/or new features come with corresponding tests.
    N/A
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.
    N/A

The `uv.lock` file is auto-generated. It should not need formatting.
Recent changes in `identify`, a dependency of `pretty-format-toml` added
a rule to identify `uv.lock` as a `toml` file. Due to this change, the
file got automatically picked up by the pre-commit worfklow for linting
as a `toml`-file (which failes because it's not formatted as expected).

We only see this change on CI because for the `pre-commit` workflow, we
don't pin exact versions of dependencies and thus always fetch the
latest available.
Copy link
Copy Markdown
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egparedes egparedes merged commit 973b9bc into GridTools:main Mar 6, 2026
27 checks passed
@romanc romanc deleted the romanc/pretty-toml-uv-lock branch March 6, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants