Skip to content

feat[cartesian] Use default CXX all the time + Intel traceback for debug#2596

Merged
FlorianDeconinck merged 4 commits into
GridTools:mainfrom
FlorianDeconinck:feature/better_traceback_for_icx
May 11, 2026
Merged

feat[cartesian] Use default CXX all the time + Intel traceback for debug#2596
FlorianDeconinck merged 4 commits into
GridTools:mainfrom
FlorianDeconinck:feature/better_traceback_for_icx

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Contributor

Description

The original design of the cxx_compile_flags was to feed it in the GT4PY_EXTRA_COMPILE_ARGS. This means we can have user override the internal decision.
We propose to swap this strategy - we control flags.

On this PR we also had -traceback and -g to debug compile in order to gather a better stack on crash or FPE trap.

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.

@FlorianDeconinck FlorianDeconinck requested review from romanc and twicki May 8, 2026 19:08
Copy link
Copy Markdown
Contributor

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with flipping the behavior. We might wanna shoot a message to the PMAP people.

Why are "apple clang" and "clang" not getting a -g flag in case of -O0?

@FlorianDeconinck
Copy link
Copy Markdown
Contributor Author

I'm fine with flipping the behavior. We might wanna shoot a message to the PMAP people.

Why are "apple clang" and "clang" not getting a -g flag in case of -O0?

Good catch, added.

Copy link
Copy Markdown
Contributor

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FlorianDeconinck FlorianDeconinck merged commit 32bded9 into GridTools:main May 11, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants