Skip to content

fix[cartesian] No OpenMP on device compile#2602

Merged
romanc merged 1 commit into
GridTools:mainfrom
FlorianDeconinck:fix/no_openmp_flags_on_nvcc_or_rocm
May 19, 2026
Merged

fix[cartesian] No OpenMP on device compile#2602
romanc merged 1 commit into
GridTools:mainfrom
FlorianDeconinck:fix/no_openmp_flags_on_nvcc_or_rocm

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Contributor

Description

Do not apply open_mp flags on device compilers - we don't do multithreading host code for GPU backends (and device is plain wrong).

This flag usage was discovered in the case of an icx/nvcc where the -qopenmp intel flag bled into the command line of nvcc.

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.

@FlorianDeconinck FlorianDeconinck requested review from romanc and twicki May 12, 2026 19:51
Copy link
Copy Markdown
Contributor

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@romanc romanc merged commit eef3c0e into GridTools:main May 19, 2026
22 checks passed
@romanc romanc deleted the fix/no_openmp_flags_on_nvcc_or_rocm branch May 19, 2026 06:04
edopao pushed a commit to edopao/gt4py that referenced this pull request May 21, 2026
## Description

Do not apply `open_mp` flags on device compilers - we don't do
multithreading host code for GPU backends (and device is plain wrong).

This flag usage was discovered in the case of an `icx/nvcc` where the
`-qopenmp` intel flag bled into the command line of `nvcc`.

## Requirements

- [ ] All fixes and/or new features come with corresponding tests.
- [ ] Important design decisions have been documented in the appropriate
ADR inside the [docs/development/ADRs/](docs/development/ADRs/README.md)
folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants