-
Notifications
You must be signed in to change notification settings - Fork 55
Support external imports in functions #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c37c7a3
Support external imports in functions
jdahm 37abb5c
Pass empty dict if no externals
jdahm 8feffb1
Apply suggestions from code review
jdahm 563d8cb
Formatted
jdahm 91b98d8
Fix recursive import
jdahm 4855612
Move back annotation
jdahm c69e226
Add another test for corner case
jdahm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -175,6 +175,64 @@ def definition_func(inout_field: gtscript.Field[float]): | |
| stmt = def_ir.computations[0].body.stmts[0] | ||
| assert isinstance(stmt.value, gt_ir.ScalarLiteral) and stmt.value.value == 1 | ||
|
|
||
| def test_function_import(self, id_version): | ||
| module = f"TestInlinedExternals_test_recursive_imports_{id_version}" | ||
|
|
||
| def some_function(): | ||
| from __externals__ import const | ||
|
|
||
| return const | ||
|
|
||
| def definition_func(inout_field: gtscript.Field[float]): | ||
| from __externals__ import some_call | ||
|
|
||
| with computation(PARALLEL), interval(...): | ||
| inout_field = some_call() | ||
|
|
||
| stencil_id, def_ir = compile_definition( | ||
| definition_func, | ||
| "test_recursive_imports", | ||
| module, | ||
| externals={"some_call": some_function, "const": GLOBAL_CONSTANT}, | ||
| ) | ||
| assert set(def_ir.externals.keys()) == { | ||
| "some_call", | ||
| "const", | ||
| } | ||
|
|
||
| def test_recursive_imports(self, id_version): | ||
| module = f"TestInlinedExternals_test_recursive_imports_{id_version}" | ||
|
|
||
| def func_nest2(): | ||
| from __externals__ import const | ||
|
|
||
| return const | ||
|
|
||
| def func_nest1(): | ||
| from __externals__ import other | ||
|
|
||
| return other() + func_nest2() | ||
|
|
||
| def definition_func(inout_field: gtscript.Field[float]): | ||
| from __externals__ import some_call | ||
|
|
||
| with computation(PARALLEL), interval(...): | ||
| inout_field = func_nest1() + some_call() | ||
|
|
||
| stencil_id, def_ir = compile_definition( | ||
| definition_func, | ||
| "test_recursive_imports", | ||
| module, | ||
| externals={"some_call": func_nest1, "other": func_nest2, "const": GLOBAL_CONSTANT}, | ||
| ) | ||
| assert set(def_ir.externals.keys()) == { | ||
| "some_call", | ||
| "const", | ||
| "other", | ||
| "func_nest1", | ||
| "tests.test_unittest.test_gtscript_frontend.func_nest1.func_nest2", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Externals captured implicitly get the fully qualified name. |
||
| } | ||
|
|
||
| def test_decorated_freeze(self): | ||
| A = 0 | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reasons that still elude me, this test is necessary. I thought this was covered below, but this uncovered the need for the additional annotate call at gtscript_frontend.py:1477.