GTC: Lower dimensional fields#327
GTC: Lower dimensional fields#327DropD merged 51 commits intoGridTools:masterfrom jdahm:gtc-field-dims
Conversation
Should be broken.
Temporaries are all 3D
|
I added some output checks to the generate test (had to change it a bit to not access undefined values). Surprisingly |
|
bors try |
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
|
bors try |
tehrengruber
left a comment
tehrengruber
left a comment
There was a problem hiding this comment.
Looks good so far, just minor things I overlooked in my last review.
|
|
||
|
|
||
| def dimension_flags_to_names(mask: Tuple[bool, bool, bool]) -> str: | ||
| labels = ["i", "j", "k"] |
There was a problem hiding this comment.
I'm not a fan of the LatLonGrid class, but for the sake of consistency should the names come from the same places as previously:
Domain.LatLonGrid().axes_names
There was a problem hiding this comment.
Since this PR is about introducing gtc support for lower dims I refuse to increase dependencies on the old toolchain here. Can be done somewhere else if justified.
There was a problem hiding this comment.
Sure, I have added a comment to remove the dependency on LatLonGrid above.
|
bors try |
tryAlready running a review |
tehrengruber
left a comment
tehrengruber
left a comment
There was a problem hiding this comment.
Last round I assume :-)
|
|
||
|
|
||
| def dimension_flags_to_names(mask: Tuple[bool, bool, bool]) -> str: | ||
| labels = ["i", "j", "k"] |
There was a problem hiding this comment.
Sure, I have added a comment to remove the dependency on LatLonGrid above.
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
4 participants
Description
Implement lower dimensional fields in GTC. Higher dimensional fields will follow in a separate PR.