Skip to content

Improved call-time checks#4

Merged
gronerl merged 6 commits intoGridTools:masterfrom
gronerl:field_checks
Dec 11, 2019
Merged

Improved call-time checks#4
gronerl merged 6 commits intoGridTools:masterfrom
gronerl:field_checks

Conversation

@gronerl
Copy link
Copy Markdown
Contributor

@gronerl gronerl commented Dec 10, 2019

  • check that the dtype of fields agrees with field_info
  • check that fields have a compatible layout
  • check that fields have a compatible type (ndarray, gt_storage.Storage)
  • removed erroneous test for max. domain size from c++ template
  • allow numpy int types in origin and domain parameter in call interface and storage constructor
  • renamed call_run to _call_run

Linus Groner added 4 commits December 10, 2019 12:13
check in call_run if fields are of compatible type and layout, which …
2caa5fa 
…requires moving the StencilObject class from definitions.py to a new separate file (stencil_object.py)
fixed parameter checks, cleanup of old, commented-out code
1867dd8
removed unnecessary, wrong check from c++, added test to verify corre…
9fb75e2 
…ctness
* renamed call_run to _call_run to make clear that it is not part of …
e300ccb 
…the gt4py user interface.

* accepting numpy integer types for domain, origin in call and storage interfaces
@gronerl gronerl requested a review from egparedes December 10, 2019 15:49
egparedes
egparedes requested changes Dec 10, 2019
View reviewed changes
Comment thread src/gt4py/stencil_object.py Outdated
Comment thread src/gt4py/stencil_object.py Outdated
Comment thread src/gt4py/stencil_object.py Outdated
Comment thread src/gt4py/stencil_object.py Outdated
Comment thread src/gt4py/stencil_object.py Outdated
Comment thread src/gt4py/stencil_object.py Outdated
Comment thread src/gt4py/backend/concepts.py Outdated
Comment thread src/gt4py/definitions.py
Comment thread src/gt4py/stencil_object.py
Comment thread tests/test_unittest/test_call_interface.py
@egparedes
Copy link
Copy Markdown
Contributor

egparedes commented Dec 10, 2019

It looks good to me, except for the bug when passing ndarrays to origin and/or domain and the missing f-strings

changed some .format to f-strings, support for NumPy ndarrays instead…
0b350b2 
… of tuples for domain and origin parameters
@gronerl gronerl merged commit 607bfc5 into GridTools:master Dec 11, 2019
fthaler pushed a commit to fthaler/gt4py that referenced this pull request Jan 20, 2021
@havogt
Add SymbolRef validation (GridTools#4)
f550019
abishekg7 pushed a commit to abishekg7/gt4py that referenced this pull request Sep 6, 2022
@nfarabullini
Merge pull request GridTools#4 from GridTools/functional
e49e8c1 
Functional
philip-paul-mueller pushed a commit to philip-paul-mueller/gt4py that referenced this pull request Jul 3, 2024
@edopao
Merge pull request GridTools#4 from edopao/dace-fieldview-refactor_im…
e4718b0 
…ports

Refactoring: import modules, not symbols
stubbiali referenced this pull request in stubbiali/gt4py Jan 31, 2025
@FlorianDeconinck
Move to field.at(K=...) syntax (#4)
e9bced6 
Co-authored-by: Florian Deconinck <florian.deconinck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egparedes egparedes egparedes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gronerl @egparedes