[Bug]: Server Mods not getting copied

[ClaudiusMinimus]

What happened?

In the last few builds when I do my first test run, often server mods are missing. The server does not start due to missing dependencies

What did you expect to happen?

All mods except for those in the Clientside mod list are to be copied to the server mods folder

Version

4.0.1

Relevant log output

modloader_installer.log
serverpackcreator.log

Anything else you would like to add?

In this last case, it was the mods, Patchouli-1.18.2-71.1.jar and Incorporeal-3-forge-1.18.2-5.jar

If you are using the webservice, in which browers did you encounter this bug?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[Griefed]

Heya ClaudiusMinimus,

thanks for opening this issue and for including the serverpackcreator.log!

I can confirm that both, Incorporeal-3-forge-1.18.2-5.jar and Patchouli-1.18.2-71.1.jar, should be included, as per their mods.toml definitions.

modLoader = "javafml"
loaderVersion = "[39,)"
license = "LGPL-3.0-or-later"
issueTrackerURL = "https://github.com/quat1024/incorporeal-3/issues"
logoFile = "wide_lores_banner.png"

[[mods]]
modId = "incorporeal"
version = "1.18.2-5"
displayName = "Incorporeal 3"
description = "Addon to a magic mod. More toys for Botania corporea dorks."
authors = "quaternary"
credits = "artemisSystem, Dudblockman, SnazzGass, jaredlll08, Darkhax, all the Botania nerds, and everyone who puts up with me"

[[dependencies.incorporeal]]
modId="forge"
mandatory=true
versionRange="[40.0.35,)"

[[dependencies.incorporeal]]
modId="botania"
mandatory=true
ordering="AFTER"
versionRange="*"

modLoader="javafml"
license="CC BY-NC-SA 3.0"
loaderVersion="[40,)"
issueTrackerURL="https://github.com/Vazkii/Patchouli"
logoFile="logo.png"

[[mods]]
modId="patchouli"
displayName="Patchouli"
version="${file.jarVersion}"
authors="Vazkii"
description='''
Accessible, Data-Driven, Dependency-Free Documentation for Minecraft Modders and Pack Makers
'''

[[dependencies.patchouli]]
modId="forge"
mandatory=true
versionRange="[40.1.51,)"

So this is definitely a bug in the autodetection-system. I'll fix it in the coming days.
In the meantime, you may include them in your server pack by either

1. Deactivating the autodetection-system, or
2. Specifying them as files to be included, which will override the auto-exclusion, using mods/Patchouli-1.18.2-71.1.jar;mods/Patchouli-1.18.2-71.1.jar and mods/Incorporeal-3-forge-1.18.2-5.jar;mods/Incorporeal-3-forge-1.18.2-5.jar

Cheers,
Griefed

[ClaudiusMinimus]

Hey Griefed,

Glad the logs help. I know I appreciate it when players provide me with as much info as possible, so I like to do the same for others.

Thanks! This worked perfectly!
mods/Patchouli-1.18.2-71.1.jar;mods/Patchouli-1.18.2-71.1.jar and mods/Incorporeal-3-forge-1.18.2-5.jar;mods/Incorporeal-3-forge-1.18.2-5.jar

I realized this may also solve another issue I have had. In the past, I have to go in and manually delete the config files/folders I want to be excluded. However, I could just include the files/folders as I did above.

Thanks again!
CM

BTW: I also appreciate the great support you always offer! And you have done a nice job with the documentation - had not seen that before.

[ClaudiusMinimus]

I just tried to apply the same to my configs using this

config/ftbquests;config/ftbquests, config/bcc-common.toml;config/bcc-common.toml, config/spawnermod.json;config/spawnermod.json, defaultconfigs, kubejs, mods, patchouli_books, mods/Patchouli-1.18.2-71.1.jar;mods/Patchouli-1.18.2-71.1.jar, mods/Incorporeal-3-forge-1.18.2-5.jar;mods/Incorporeal-3-forge-1.18.2-5.jar

Also tried:

config/ftbquests, config/bcc-common.toml;config/bcc-common.toml, config/spawnermod.json;config/spawnermod.json, defaultconfigs, kubejs, mods, patchouli_books, mods/Patchouli-1.18.2-71.1.jar;mods/Patchouli-1.18.2-71.1.jar, mods/Incorporeal-3-forge-1.18.2-5.jar;mods/Incorporeal-3-forge-1.18.2-5.jar

However, config/ftbquests was copied to /ftbquests

[Griefed]

Thank you very much for the detailed information regarding your issue(s) with ServerPackCreator!

You have no idea how much this helps with debugging, finding the issue and fixing it. 😁

[Griefed]

Both issues have been fixed in 4.0.3. Please give it a go. :)

Cheers,
Griefed

[ClaudiusMinimus]

Will do, I'm doing a build tomorrw.

[alterNERDtive]

Hello!

I seem to be having a similar issue. appleskin, ArchitectsPalette and Patchouli wouldn’t be copied. After upgrading from 4.0.0 to 4.0.4, it’s fixed for the latter two; appleskin still will not be copied.

I am assuming that is because it incorrectly states being client only in its mods.toml (removing the line in there fixes it). I would, however, expect it to be included nonetheless if I add it to the inclusion list. Which it, sadly, is not.

Also your wiki seems to be experiencing issues so I cannot try the “disable auto detection” fix :)

[Griefed]

Heya alterNERDtive,

how did you try to include appleskin in your server pack?

Thanks for the info about the wiki. :D I'll take a look.