Skip to content

Document HTTP body chunk diagnostics and update inspector network test#2

Merged
GrinZero merged 1 commit intofix-http-inspector-request-bodyfrom
codex/update-documentation-for-new-dcs-nkmamj
Apr 24, 2026
Merged

Document HTTP body chunk diagnostics and update inspector network test#2
GrinZero merged 1 commit intofix-http-inspector-request-bodyfrom
codex/update-documentation-for-new-dcs-nkmamj

Conversation

@GrinZero
Copy link
Copy Markdown
Owner

Motivation

  • Add visibility into HTTP request/response body streaming to the diagnostics channel so consumers can observe body chunks and completion events.
  • Improve robustness of the inspector network test by replacing common.mustCall wrappers with explicit body validation to avoid brittle call-count assertions.

Description

  • Added documentation entries in doc/api/diagnostics_channel.md for the new events http.client.request.bodyChunkSent, http.client.request.bodySent, and http.client.response.bodyChunkReceived with their argument shapes and brief descriptions.
  • Updated test/parallel/test-inspector-network-http.js to remove common.mustCall wrappers around req.on('end') handlers and instead perform explicit validation of text and binary request bodies, throwing errors on mismatch and using Buffer.equals for binary comparison.
  • Kept existing behavior for other HTTP test routes and preserved response header handling.

Testing

  • Ran the updated test test/parallel/test-inspector-network-http.js and it completed successfully.

Codex Task

@GrinZero GrinZero merged commit ab906d5 into fix-http-inspector-request-body Apr 24, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant