Document HTTP body chunk diagnostics and update inspector network test#2
Merged
GrinZero merged 1 commit intofix-http-inspector-request-bodyfrom Apr 24, 2026
Conversation
ab906d5
into
fix-http-inspector-request-body
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
common.mustCallwrappers with explicit body validation to avoid brittle call-count assertions.Description
doc/api/diagnostics_channel.mdfor the new eventshttp.client.request.bodyChunkSent,http.client.request.bodySent, andhttp.client.response.bodyChunkReceivedwith their argument shapes and brief descriptions.test/parallel/test-inspector-network-http.jsto removecommon.mustCallwrappers aroundreq.on('end')handlers and instead perform explicit validation of text and binary request bodies, throwing errors on mismatch and usingBuffer.equalsfor binary comparison.Testing
test/parallel/test-inspector-network-http.jsand it completed successfully.Codex Task