Explicitly use functions from the Configurator namespace #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit use function imports for Symfony Configurator namespace functions in the generated PHP configuration files to improve static analysis tool support.
- Adds explicit function imports for Configurator namespace functions to help static analysis tools
- Includes imports for 9 functions:
service,inline_service,service_locator,iterator,expr,abstract_arg,env,service_closure, andclosure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
Thanks. I don't think that's in the spirit of the feature. We're in the |
mpdude
added a commit
to webfactory/WebfactoryShortcodeBundle
that referenced
this pull request
Nov 24, 2025
XML-based service configuration has been deprecated since symfony/symfony#60568 and will no longer be supported in Symfony 8.0. See also https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration. In order for ComposerRequireChecker to recognise where the functions come from, we have to import them explicitly. At the same time, PHP-CS-Fixer must not remove the import, which is actually superfluous. X-Ref GromNaN/symfony-config-xml-to-php#29, maglnet/ComposerRequireChecker#193 (comment)
mpdude
added a commit
to webfactory/WebfactoryHttpCacheBundle
that referenced
this pull request
Nov 29, 2025
XML-based service configuration has been deprecated since symfony/symfony#60568 and will no longer be supported in Symfony 8.0. See also https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration. In order for ComposerRequireChecker to recognise where the functions come from, we have to import them explicitly. At the same time, PHP-CS-Fixer must not remove the import, which is actually superfluous. X-Ref GromNaN/symfony-config-xml-to-php#29, maglnet/ComposerRequireChecker#193 (comment)
mpdude
added a commit
to webfactory/WebfactoryHttpCacheBundle
that referenced
this pull request
Nov 29, 2025
XML-based service configuration has been deprecated since symfony/symfony#60568 and will no longer be supported in Symfony 8.0. See also https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration. In order for ComposerRequireChecker to recognise where the functions come from, we have to import them explicitly. At the same time, PHP-CS-Fixer must not remove the import, which is actually superfluous. X-Ref GromNaN/symfony-config-xml-to-php#29, maglnet/ComposerRequireChecker#193 (comment)
Owner
|
I'm rejecting as this is not necessary nor expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds namespace imports for functions from the
Symfony\Component\DependencyInjection\Loader\Configuratornamespace on top of the generated files.Technically, those imports are not necessary at runtime, since the functions can be resolved correctly without.
However, it makes a difference for tools like ComposerRequireChecker that have to rely purely on static analysis (SA).
With SA alone, function imports may be ambiguous (see maglnet/ComposerRequireChecker#193 (comment)).
By adding these imports, we add more static information.