Amir deris/provide path variable safely to llm#25
Merged
amir-deris merged 6 commits intomainfrom Sep 4, 2025
Merged
Conversation
amir-deris
commented
Sep 1, 2025
| pathDirectories := strings.Split(path, string(os.PathListSeparator)) | ||
| for _, d := range pathDirectories { | ||
| pathParts := strings.Split(d, string(os.PathSeparator)) | ||
| programName := pathParts[len(pathParts)-2:] |
Collaborator
Author
There was a problem hiding this comment.
I thought for security reasons not including the full path name which can include username, etc. Took the last two parts of each directory path (to distinguish between multiple bin folders)
masih
approved these changes
Sep 1, 2025
Collaborator
masih
left a comment
masih
left a comment
There was a problem hiding this comment.
Great start. Feel free to expand the executable search here or in a separate PR
| for _, d := range pathDirectories { | ||
| pathParts := strings.Split(d, string(os.PathSeparator)) | ||
| programName := pathParts[len(pathParts)-2:] | ||
| result = append(result, strings.Join(programName, string(os.PathSeparator))) |
Collaborator
There was a problem hiding this comment.
This is a good start but I think we need to list all executables in the path directory for this to be effective.
I say all but I mean some confined set.
Collaborator
Author
There was a problem hiding this comment.
That's a good point. I will make the change for that and keep you posted.
amir-deris
commented
Sep 2, 2025
amir-deris
deleted the
amir-deris/provide-path-variable-safely-to-llm
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added path content to llm for better command suggestion
Added unit test
Fixes #22