fix(http): use single hop trust proxy to prevent rate limit bypass#1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What
trustProxyfromtrueto1inconfig/env/production.js🤷♂️ Why
express-rate-limitv7+ rejectstrustProxy: truebecause it trusts all proxies unconditionally, allowing attackers to spoofX-Forwarded-Forand bypass IP-based rate limiting (ERR_ERL_PERMISSIVE_TRUST_PROXY).Setting it to
1tells Express to trust exactly one proxy hop (the Azure App Service load balancer), which still resolvesreq.ipto the real client IP while preventing spoofing.🔍 How
Single-line change:
trustProxy: true→trustProxy: 1. Express interprets the number as "trust the nth hop from the front-facing proxy," which is the correct setting for Azure App Service's single LB architecture.🧪 Testing
After deployment, verify:
169.254.129.1)ERR_ERL_PERMISSIVE_TRUST_PROXYvalidation error is gone📸 Previews
N/A