GemStone update

.github/workflows/build.yml

@@ -0,0 +1,27 @@
+name: Build
+
+on: [push,pull_request,workflow_dispatch]
+
+jobs:
+   build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        smalltalk: [ Pharo64-7.0, Pharo64-8.0, Pharo64-9.0, Pharo64-10, Pharo64-11, Pharo64-12, Pharo64-13 ]
+    name: ${{ matrix.smalltalk }}
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Smalltalk CI
+        uses: hpi-swa/setup-smalltalkCI@v1
+        with:
+          smalltalk-image: ${{ matrix.smalltalk }}
+      - name: Load Image and Run Tests
+        run: smalltalkci -s ${{ matrix.smalltalk }} .smalltalkci/.unit-tests.ston
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        timeout-minutes: 15
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v1
+        with:
+          name: ${{matrix.os}}-${{matrix.smalltalk}}
+          token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/ci.yml

@@ -13,8 +13,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-20.04, macos-latest ]
-        smalltalk: [ GemStone64-3.5.3, GemStone64-3.5.8,  GemStone64-3.6.0, GemStone64-3.6.5 ]
+        os: [ ubuntu-latest ]
+        smalltalk: [ GemStone64-3.7.2, GemStone64-3.7.4.3 ]
     runs-on: ${{ matrix.os }}
     name: ${{ matrix.smalltalk }}
     steps:
@@ -31,7 +31,7 @@ jobs:
     name: Post Workflow Status To Slack
     needs:
       - build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
        - name: Slack Workflow Notification
          uses: Gamesight/slack-workflow-status@master

.smalltalk_gemstone.ston

@@ -1,10 +1,10 @@
 SmalltalkCISpec {
-	#loading : [
-		SCIMetacelloLoadSpec {
-			#baseline : 'BitmapCharacterSet',
-			#directory : 'filetree',
-			#load : [ 'Tests' ],
-			#platforms : [ #gemstone]
-		}
-	]
+    #loading : [
+        SCIMetacelloLoadSpec {
+            #baseline : 'BitmapCharacterSet',
+            #directory : 'filetree',
+            #load : [ 'Tests' ],
+            #platforms : [ #gemstone]
+        }
+    ]
 }

.smalltalkci/.unit-tests.ston

@@ -0,0 +1,16 @@
+SmalltalkCISpec {
+  #loading : [
+    SCIMetacelloLoadSpec {
+      #baseline : 'BitmapCharacterSet',
+      #directory : '../src',
+      #load : [ 'CI' ],
+      #platforms : [  #pharo ]
+    }
+  ],
+  #testing : {
+    #coverage : {
+      #packages : [ 'Collections*' ],
+      #format: #lcov
+    }
+  }
+}

.travis_pharo.yml

@@ -6,3 +6,4 @@ os:
 
 smalltalk:
  - Pharo-7.0
+

README.md

@@ -1,6 +1,18 @@
 # BitmapCharacterSet [![Build Status](https://github.com/GsDevKit/BitmapCharacterSet/actions/workflows/ci.yml/badge.svg?branch=gemstone)](https://github.com/GsDevKit/BitmapCharacterSet/actions/workflows/ci.yml)
 
-BitmapCharacterSet is a set for characters that uses a bitmap for storing wide characters and an array of truth values for byte characters. Used by XMLParser.
+**BitmapCharacterSet** is a set for characters that uses a bitmap for storing wide characters and an array of truth values for byte characters in [Pharo](https://www.pharo.org). Used by [XMLParser](https://github.com/pharo-contributions/XML-XMLParser).
+
+
+[![Unit Tests](https://github.com/pharo-contributions/BitmapCharacterSet/workflows/Build/badge.svg?branch=master)](https://github.com/pharo-contributions/BitmapCharacterSet/actions?query=workflow%3ABuild)
+[![Coverage Status](https://codecov.io/github/pharo-contributions/BitmapCharacterSet/coverage.svg?branch=master)](https://codecov.io/gh/pharo-contributions/BitmapCharacterSet/branch/master)
+
+[![Pharo 7](https://img.shields.io/badge/Pharo-7.0-%23aac9ff.svg)](https://pharo.org/download)
+[![Pharo 8](https://img.shields.io/badge/Pharo-8.0-%23aac9ff.svg)](https://pharo.org/download)
+[![Pharo 9](https://img.shields.io/badge/Pharo-9.0-%23aac9ff.svg)](https://pharo.org/download)
+[![Pharo 10](https://img.shields.io/badge/Pharo-10-%23aac9ff.svg)](https://pharo.org/download)
+[![Pharo 11](https://img.shields.io/badge/Pharo-11-%23aac9ff.svg)](https://pharo.org/download)
+[![Pharo 12](https://img.shields.io/badge/Pharo-12-%23aac9ff.svg)](https://pharo.org/download)
+[![Pharo 13](https://img.shields.io/badge/Pharo-13-%23aac9ff.svg)](https://pharo.org/download)
 
 ## Installation
 

filetree/BaselineOfBitmapCharacterSet.package/BaselineOfBitmapCharacterSet.class/instance/baseline..st

@@ -5,13 +5,14 @@ baseline: spec
 	spec for: #common do: [ 
 		"Packages and Dependencies"
 		spec 
-			package: 'Collections-BitmapCharacterSet-Core';
-			package: 'Collections-BitmapCharacterSet-Tests' with: [ spec requires: 'Collections-BitmapCharacterSet-Core' ].
+			package: 'Collections-BitmapCharacterSet-Base';
+			package: 'Collections-BitmapCharacterSet-Tests' with: [ spec requires: 'Collections-BitmapCharacterSet-Base' ].
 
 		"Groups"	
 		spec				
-				group: 'Core' with: #('Collections-BitmapCharacterSet-Core');
+				group: 'Core' with: #('Collections-BitmapCharacterSet-Base');
 				group: 'Tests' with: #('Collections-BitmapCharacterSet-Tests');
+				group: 'CI' with: #('Tests');
 				group: 'all' with: #('Core' 'Tests');
 				group: 'default' with: #('all')	
 	]

filetree/Collections-BitmapCharacterSet-Core.package/BitmapCharacterSet.class/properties.json → filetree/Collections-BitmapCharacterSet-Base.package/BitmapCharacterSet.class/properties.json

@@ -1,5 +1,5 @@
 {
-	"category" : "Collections-BitmapCharacterSet-Core",
+	"category" : "Collections-BitmapCharacterSet-Base",
 	"classinstvars" : [
 		 ],
 	"classvars" : [

filetree/Collections-BitmapCharacterSet-Core.package/monticello.meta/categories.st → filetree/Collections-BitmapCharacterSet-Base.package/monticello.meta/categories.st

@@ -1 +1 @@
-SystemOrganization addCategory: #'Collections-BitmapCharacterSet-Core'!
+SystemOrganization addCategory: #'Collections-BitmapCharacterSet-Base'!

filetree/Collections-BitmapCharacterSet-Base.package/monticello.meta/package

@@ -0,0 +1 @@
+(name 'Collections-BitmapCharacterSet-Base')

filetree/Collections-BitmapCharacterSet-Tests.package/BitmapCharacterSetTest.class/instance/assertSet.copiedFrom.equals..st

@@ -3,8 +3,8 @@ assertSet: aFirstSet copiedFrom: aSecondSet equals: aThirdSet
 	self
 		deny: aFirstSet == aSecondSet;
 		deny: aFirstSet byteCharacters == aSecondSet byteCharacters.
-	(aFirstSet wideCharacters notNil
-		or: [aSecondSet wideCharacters notNil])
+	(aFirstSet wideCharacters isNil not
+		or: [aSecondSet wideCharacters isNil not])
 		ifTrue: [self deny: aFirstSet wideCharacters == aSecondSet wideCharacters].
-	
+
 	self assert: aFirstSet = aThirdSet.

filetree/Collections-BitmapCharacterSet-Tests.package/BitmapCharacterSetTest.class/instance/testMaxCharacter.st

@@ -3,10 +3,8 @@ testMaxCharacter
 	| set |
 
 	set := self emptySet.
-	self
-		shouldnt: [set add: self lastCodePoint asCharacter]
-		raise: Error.
+	set add: self lastCodePoint asCharacter.
 	self assert: (set includes: self lastCodePoint asCharacter).
 	self
-		should: [set add: (self lastCodePoint + 1) asCharacter]
+		should: [ set add: (self lastCodePoint + 1) asCharacter ]
 		raise: Error.

filetree/Collections-BitmapCharacterSet-Tests.package/BitmapCharacterSetTest.class/instance/testRemoveIfAbsent.st

@@ -3,17 +3,11 @@ testRemoveIfAbsent
 	| set |
 
 	set := self nonEmptySet.
-	self absentCharactersDo: [:each |
-		self assert:
-			(set
-				remove: each
-				ifAbsent: [#absent]) = #absent].
-	self charactersDo: [:each |
-		self assert:
-			(set
-				remove: each
-				ifAbsent: [self fail]) = each.
-		self assert:
-			(set
-				remove: each
-				ifAbsent: [#absent]) = #absent].
+	self absentCharactersDo: [ :each |
+		self
+			assert:(set remove: each ifAbsent: [ #absent ]) = #absent ].
+	self charactersDo: [ :each |
+		self
+			assert: (set remove: each ifAbsent: [ self fail ]) = each.
+		self
+			assert: (set remove: each ifAbsent: [ #absent ]) = #absent ].

filetree/Collections-BitmapCharacterSet-Tests.package/BitmapCharacterSetTest.class/instance/testSize.st

@@ -4,17 +4,16 @@ testSize
 
 	set := self emptySet.
 	size := 0.
-	self charactersDo: [:each |
+	self charactersDo: [ :each |
 		self assert: set size = size.
 		set add: each.
 		size := size + 1.
 		self assert: set size = size.
-
 		"Adding the same character shouldn't alter the size"
 		set add: each.
-		self assert: set size = size.].
+		self assert: set size = size ].
 
-	self charactersDo: [:each |
+	self charactersDo: [ :each |
 		set remove: each.
 		size := size - 1.
-		self assert: set size = size].	
+		self assert: set size = size ].	

filetree/Collections-BitmapCharacterSet-Tests.package/BitmapCharacterSetTest.class/instance/testWideCharacters.st

@@ -1,18 +1,20 @@
 tests
 testWideCharacters
-	0 to: 7 do: [:i | | set character |
+	0 to: 7 do: [ :i |
+		| set character |
 		set := self setClass new.
 		character := (256 + i) asCharacter.
 		self assert: set wideCharacters isNil.
 		set add: character.
 		self assert: set wideCharacters first = (16r80 bitShift: i negated).
 		set remove: character.
-		self assert: set wideCharacters first = 0].
-	0 to: 7 do: [:i | | set character |
+		self assert: set wideCharacters first = 0 ].
+	0 to: 7 do: [ :i |
+		| set character |
 		set := self setClass new.
 		character := (256 + 8 + i) asCharacter.
 		self assert: set wideCharacters isNil.
 		set add: character.
 		self assert: set wideCharacters second = (16r80 bitShift: i negated).
 		set remove: character.
-		self assert: set wideCharacters second = 0]
+		self assert: set wideCharacters second = 0 ]

filetree/Collections-BitmapCharacterSet-Tests.package/BitmapCharacterSetTest.class/properties.json

@@ -1,5 +1,5 @@
 {
-	"category" : "Collections-BitmapCharacterSet-Tests",
+	"category" : "Collections-BitmapCharacterSet-Tests-Base",
 	"classinstvars" : [
 		 ],
 	"classvars" : [

filetree/Collections-BitmapCharacterSet-Tests.package/monticello.meta/categories.st

@@ -1 +1 @@
-SystemOrganization addCategory: #'Collections-BitmapCharacterSet-Tests'!
+SystemOrganization addCategory: #'Collections-BitmapCharacterSet-Tests-Base'!