Fix a lot of "TODO PORT" sections#1384
Conversation
|
look wonderful ! I'll test dual monitoring later this week or next week, but if it is broken i'll fix it, do not worry. Can you add a |
gsemet
left a comment
gsemet
left a comment
There was a problem hiding this comment.
just the paths.py that should not be commited
| @@ -0,0 +1,98 @@ | |||
| # -*- coding: utf-8; -*- | |||
There was a problem hiding this comment.
normally you do not commit this file is automatically generated by the makefile
There was a problem hiding this comment.
Of course, you are right!
I rebased and removed the file.
load default font via python Gio and not via cli call test and add json example for custom commands port screen selection (use mouse) to Gdk add notification for failed show-hide key combinations settings port one-click keyboard settings port word char exceptions replace Gtk.HBox with Gtk.Box+Gtk.Orientation.HORIZONTAL
aichingm
force-pushed
the
dev/todo-port
branch
from
356fdc1 to
4103300
Compare
|
I have already done the rewrite of the notebook to allow for multiple terminals in one page, just waiting for this to be merged to keep the PRs small. It is not the most beautiful code jet since this is only step 3. and not all relevant functions are moved from guake_app.py to notebook.py but its a good start. |
|
thanks a lot ! |
2 participants
There are still some
TODO PORTsections left but I can't test stuff related to Unity and appindecator since I don't have a 16.-- Ubuntu box running...I ported the monitor selection when using the "use_mouse" option to Gdk since the Gtk parts are deprecated, but some one should test them (I have currently only my laptop with me and no access to a second monitor)
I also changed https://github.com/Guake/guake/compare/master...aichingm:dev/todo-port?expand=1#diff-7a93ec37877f9e75dacff02a373a6734R39
and added a
run-prefsmake target to make development of the prefs window more enjoyable.