-
Notifications
You must be signed in to change notification settings - Fork 6
75 forms inputs #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
punitrathore
merged 10 commits into
GuildCrafts:master
from
TrevorJamesH:75-forms-inputs
Apr 13, 2017
Merged
75 forms inputs #92
punitrathore
merged 10 commits into
GuildCrafts:master
from
TrevorJamesH:75-forms-inputs
Apr 13, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds checkbox to create question dialog
- Uses checkbox atom on create qusetion form
Removes unneeded imports since form holds inputs Leaves comment for copying formatting of SelectTag
app.js
Outdated
| app.use(express.static(__dirname + '/src/browser/main.js')); | ||
|
|
||
| authInitialize(app) | ||
| // authInitialize(app) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be commited :)
Pulls text parsing out into function
Fixes formatting of Form Input list on header
dc11db2 to
ed89192
Compare
lumodon
added a commit
to TrevorJamesH/interview-app
that referenced
this pull request
Apr 14, 2017
commit 58c580c Merge: 071f58c ec730ee Author: Serafin <leaf466@gmail.com> Date: Thu Apr 13 17:39:22 2017 -0700 Merge branch '75-forms-inputs' of github.com:TrevorJamesH/interview-app into 75-forms-inputs commit 071f58c Merge: ed89192 048516f Author: Serafin <leaf466@gmail.com> Date: Thu Apr 13 17:38:42 2017 -0700 Merge branch 'master' into 75-forms-inputs commit ec730ee Author: TrevorJamesH <jetsamrover@gmail.com> Date: Thu Apr 13 17:38:42 2017 -0700 Moved init function calls to contructor commit 048516f Author: Trevor <jetsamrover@gmail.com> Date: Thu Apr 13 16:17:44 2017 -0700 75 forms inputs (GuildCrafts#92) * Adds radio button atom and places it on header * Creates form-checkbox - Adds checkbox to create question dialog * Adds checkbox atom - Uses checkbox atom on create qusetion form * Adds form molecule * Fixes up form to modify state from input of each given option * Sets default values to all form inputs * Fixes header to use two inputs Removes unneeded imports since form holds inputs Leaves comment for copying formatting of SelectTag * Removed iterators that weren't being used Pulls text parsing out into function * Adds implementation example to Form Fixes formatting of Form Input list on header commit ed89192 Author: Serafin <leaf466@gmail.com> Date: Thu Apr 13 15:26:25 2017 -0700 Adds implementation example to Form Fixes formatting of Form Input list on header commit 8655d76 Author: Serafin <leaf466@gmail.com> Date: Thu Apr 13 15:12:51 2017 -0700 Removed iterators that weren't being used Pulls text parsing out into function commit 611a939 Author: Serafin <leaf466@gmail.com> Date: Thu Apr 13 13:26:18 2017 -0700 Fixes header to use two inputs Removes unneeded imports since form holds inputs Leaves comment for copying formatting of SelectTag commit 96911f1 Author: Serafin <leaf466@gmail.com> Date: Thu Apr 13 12:42:33 2017 -0700 Sets default values to all form inputs commit 4d3619e Author: Serafin <leaf466@gmail.com> Date: Thu Apr 13 12:05:48 2017 -0700 Fixes up form to modify state from input of each given option commit 3aa5255 Author: TrevorJamesH <jetsamrover@gmail.com> Date: Wed Apr 12 15:24:44 2017 -0700 Adds form molecule commit 1f88a9a Merge: bec9579 bfa1d06 Author: Serafin <leaf466@gmail.com> Date: Wed Apr 12 11:57:23 2017 -0700 Merge branch '75-radiobuttons' into 75-checkboxed commit bec9579 Author: Serafin <leaf466@gmail.com> Date: Tue Apr 11 12:08:45 2017 -0700 Adds checkbox atom - Uses checkbox atom on create qusetion form commit c6d9df5 Author: TrevorJamesH <jetsamrover@gmail.com> Date: Mon Apr 10 17:54:20 2017 -0700 Creates form-checkbox - Adds checkbox to create question dialog commit bfa1d06 Author: Serafin <leaf466@gmail.com> Date: Wed Apr 12 10:18:54 2017 -0700 Adds radio button atom and places it on header commit 87e48aa Merge: 86b63f5 ac5dfca Author: HJBowers <HJBowers@gmail.com> Date: Tue Apr 11 17:25:07 2017 -0700 Merge branch 'master' of https://github.com/GuildCrafts/interview-app commit 86b63f5 Author: HJBowers <HJBowers@gmail.com> Date: Tue Apr 11 17:24:17 2017 -0700 Fixed the menu off-canvas feature commit ac5dfca Author: Punit Rathore <punitr@gmail.com> Date: Tue Apr 11 16:39:12 2017 -0700 adding a PR template commit 71b8fb3 Author: Lizz Katsnelson <katsnelson.lizz@gmail.com> Date: Tue Apr 11 13:30:34 2017 -0700 Adds artifact for Lizz and Hannah's team (GuildCrafts#78) commit 86d22fd Author: Serafin Wesnidge <lumodon@users.noreply.github.com> Date: Tue Apr 11 13:30:10 2017 -0700 Moves styling names from id's to classes (GuildCrafts#88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75 . (type the issue number after the
#character so that the issue is referenced)Overview
Form broken out into a molecule. Each input type with its prompt is an atom. Form inputs are stored in the state of the form at state.input
Did not add functionality to the form's submit button, leaving that to be done when connecting to a route.
Data Model / DB Schema Changes
NA
Environment / Configuration Changes
NA
Notes
NA