Skip to content

Revise Punit's contracts#167

Merged
punitrathore merged 9 commits intomasterfrom
tw/contracts-by-punit
Feb 16, 2017
Merged

Revise Punit's contracts#167
punitrathore merged 9 commits intomasterfrom
tw/contracts-by-punit

Conversation

@tannerwelsh
Copy link
Copy Markdown
Contributor

@tannerwelsh tannerwelsh commented Feb 15, 2017

Revise Punit's goals to simplify and clarify. See commit list for more specific changes.

When this PR is merged, this task also needs to get done:

  • Replace text in each corresponding goal issue to point to the contract file.

@tannerwelsh tannerwelsh self-assigned this Feb 15, 2017
@tannerwelsh
Copy link
Copy Markdown
Contributor Author

Yo @punitrathore! The other @GuildCrafts/librarians and I are working to improve our goal library, piece by piece.

The first step is for us to migrate the goals from their current home (as descriptions on GitHub issues) to files in this repository (specifically, in the contracts directory).

As we migrate them, however, we're also reviewing and revising the goals to make them more clear and concise. This often means updating the specs and/or quality rubric, and editing the description and context to do more, well, describing and contextualizing ;).

Long story short: I made some edits to your goals. Would you mind reviewing them? If they look OK to you, I'll go ahead and merge them.

Thanks!

@punitrathore
Copy link
Copy Markdown
Collaborator

@tannerwelsh This looks really really good! Thanks so much for the edits. I'm gonna use this as a model for future goals ;-) I'm merging this.

@punitrathore punitrathore merged commit 8288408 into master Feb 16, 2017
@tannerwelsh
Copy link
Copy Markdown
Contributor Author

Thanks @punitrathore!

@tannerwelsh tannerwelsh removed the request for review from punitrathore February 17, 2017 13:28
@tannerwelsh tannerwelsh deleted the tw/contracts-by-punit branch February 17, 2017 21:33
@tannerwelsh tannerwelsh removed their assignment Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants