-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/modify UI ux #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/modify UI ux #134
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
์ด PR์ ๊ฒ์ ๊ธฐ๋ฅ์ UX/UI ๊ฐ์ ๊ณผ ๋ก์ปฌ ์คํ ๋ฆฌ์ง ๊ด๋ฆฌ ๋ฐฉ์์ ๊ฐ์ ํฉ๋๋ค. ๊ธฐ์กด์ ๊ฐ ์ปดํฌ๋ํธ์์ ๋ ๋ฆฝ์ ์ผ๋ก ๋ก์ปฌ ์คํ ๋ฆฌ์ง๋ฅผ ๊ด๋ฆฌํ๋ ๋ฐฉ์์์ Zustand๋ฅผ ํ์ฉํ ์ค์ ์ง์ค์ ์ํ ๊ด๋ฆฌ๋ก ์ ํํ์ฌ ์ผ๊ด์ฑ ๋ฌธ์ ๋ฅผ ํด๊ฒฐํ์ต๋๋ค.
Changes:
- ๊ฒ์ ํ์คํ ๋ฆฌ๋ฅผ ๊ด๋ฆฌํ๋ ์ปค์คํ ํ (useSearchHistory)์ Zustand store(useSearchHistoryStore)๋ก ๋ง์ด๊ทธ๋ ์ด์
- ๊ฒ์ ๊ฒฐ๊ณผ ์นด๋ UI ๋์์ธ ๊ฐ์ ๋ฐ ์ํฐ์คํธ ํด๋ฆญ ๊ธฐ๋ฅ ์ถ๊ฐ
- ๋ค๋ฅธ store๋ค์ initialState ํจํด ํต์ผ
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/stores/useSearchHistoryStore.ts | localStorage ๊ธฐ๋ฐ ๊ฒ์ ํ์คํ ๋ฆฌ๋ฅผ Zustand persist ๋ฏธ๋ค์จ์ด๋ก ๊ตฌํํ ์๋ก์ด store ์ถ๊ฐ |
| apps/web/src/stores/useModalStore.ts | initialState ํจํด ์ ์ฉ ๋ฐ closeMessage ์ ์ด๊ธฐ ์ํ๋ก ์์ ํ ๋ฆฌ์ ํ๋๋ก ๊ฐ์ |
| apps/web/src/stores/useAuthStore.ts | initialState ํจํด ์ ์ฉ ๋ฐ logout ์ ์ด๊ธฐ ์ํ๋ก ์์ ํ ๋ฆฌ์ ํ๋๋ก ๊ฐ์ |
| apps/web/src/hooks/useSearchSong.ts | useSearchHistory hook์์ useSearchHistoryStore๋ก ๋ง์ด๊ทธ๋ ์ด์ |
| apps/web/src/hooks/useSearchHistory.ts | Zustand store๋ก ๋์ฒด๋์ด ์ญ์ ๋จ |
| apps/web/src/app/search/SearchResultCard.tsx | ์นด๋ ๋ ์ด์์ ๊ฐ์ , absolute ํฌ์ง์ ๋ ์ ๊ฑฐ, ์ํฐ์คํธ ํด๋ฆญ ๊ธฐ๋ฅ ์ถ๊ฐ |
| apps/web/src/app/search/HomePage.tsx | ScrollArea๋ฅผ ์ผ๋ฐ div๋ก ๋ณ๊ฒฝ, useEffect ์์น ์ด๋, ์ํฐ์คํธ ํด๋ฆญ ํธ๋ค๋ฌ ์ถ๊ฐ |
| apps/web/public/changelog.json | ๋ฒ์ 2.0.1 ๋ณ๊ฒฝ์ฌํญ ์ถ๊ฐ |
| apps/web/package.json | ๋ฒ์ ์ 1.9.1์์ 2.0.1๋ก ์ ๋ฐ์ดํธ |
| apps/web/GEMINI.md | ์น ์ฑ์ ๊ธฐ์ ์คํ ๋ฐ ์ปจ๋ฒค์ ๋ฌธ์ ์ถ๊ฐ |
| GEMINI.md | ํ๋ก์ ํธ ์ ์ฒด ๊ตฌ์กฐ ๋ฐ ๊ธฐ์ ์คํ ๋ฌธ์ ์ถ๊ฐ |
| .gitignore | temp/ ๋๋ ํ ๋ฆฌ ์ถ๊ฐ |
| )} | ||
| </div> | ||
| <ScrollArea className="h-[calc(100vh-24rem)]"> | ||
| <div className="h-[calc(100vh-24rem)] overflow-x-hidden overflow-y-auto"> |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScrollArea๋ฅผ ์ผ๋ฐ div๋ก ๋ณ๊ฒฝํ์ต๋๋ค. ํ๋ก์ ํธ ์ ๋ฐ์์ ScrollArea ์ปดํฌ๋ํธ๋ฅผ ์ฌ์ฉํ๊ณ ์๋ ํจํด(apps/web/src/app/info/like/page.tsx:46, apps/web/src/app/info/save/page.tsx:194, apps/web/src/app/popular/page.tsx:22, apps/web/src/app/tosing/page.tsx:29)๊ณผ ์ผ๊ด์ฑ์ด ๋จ์ด์ง๋๋ค. ํน๋ณํ ์ด์ ๊ฐ ์๋ค๋ฉด ScrollArea ์ปดํฌ๋ํธ๋ฅผ ๊ณ์ ์ฌ์ฉํ๋ ๊ฒ์ ๊ถ์ฅํฉ๋๋ค.
| <span | ||
| className="text-muted-foreground cursor-pointer truncate text-sm hover:underline" | ||
| onClick={onClickArtist} | ||
| > | ||
| {artist} | ||
| </span> |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ฐ์๋ช ์ ํด๋ฆญํ ์ ์๋ ๊ธฐ๋ฅ์ ์ถ๊ฐํ์ต๋๋ค. button ๋๋ role="button"์ ์ฌ์ฉํ๊ณ ํค๋ณด๋ ์ ๊ทผ์ฑ(onKeyDown ๋๋ onKeyPress)์ ์ถ๊ฐํ๋ ๊ฒ์ ๊ถ์ฅํฉ๋๋ค. ํ์ฌ๋ ๋ง์ฐ์ค ํด๋ฆญ๋ง ๊ฐ๋ฅํ์ฌ ํค๋ณด๋ ์ฌ์ฉ์๊ฐ ์ด ๊ธฐ๋ฅ์ ์ฌ์ฉํ ์ ์์ต๋๋ค.
apps/web/src/hooks/useSearchSong.ts
Outdated
| } | ||
|
|
||
| if (parsedSearch) { | ||
| console.log('parsedSearch ', parsedSearch); |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋๋ฒ๊น ์ฉ console.log๊ฐ ๋จ์์์ต๋๋ค. ํ๋ก๋์ ์ฝ๋์์๋ ์ ๊ฑฐํด์ฃผ์ธ์.
| console.log('parsedSearch ', parsedSearch); |
| searchHistory: [] as string[], | ||
| }; | ||
|
|
||
| export const useSearchHistoryStore = create( |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useSearchHistoryStore๋ ๋ค๋ฅธ store๋ค(useAuthStore, useModalStore)๊ณผ ๋ฌ๋ฆฌ default export๊ฐ ์๋ named export๋ก ๋์ด์์ต๋๋ค. ์ฝ๋๋ฒ ์ด์ค์ ์ผ๊ด์ฑ์ ์ํด 'export default useSearchHistoryStore'๋ก ๋ณ๊ฒฝํ๋ ๊ฒ์ ๊ถ์ฅํฉ๋๋ค. ๋ค๋ฅธ store ํ์ผ๋ค(useAuthStore.ts:264, useModalStore.ts:56)์ ์ฐธ๊ณ ํด์ฃผ์ธ์.
๐ PR ์ ๋ชฉ
Fix : ๊ฒ์ ๊ณก ์นด๋ ๋์์ธ ๊ฐ์ , ๋ก์ปฌ ์คํ ๋ฆฌ์ง ๊ฒ์์ด ์ ์ฅ ๊ธฐ๋ฅ ๊ฐ์
๐ ๋ณ๊ฒฝ ์ฌํญ
๐ฌ ์ถ๊ฐ ์ฐธ๊ณ ์ฌํญ