Skip to content

Conversation

@GulSam00
Copy link
Owner

@GulSam00 GulSam00 commented Feb 2, 2026

๐Ÿ“Œ PR ์ œ๋ชฉ

Fix : ๊ฒ€์ƒ‰ ๊ณก ์นด๋“œ ๋””์ž์ธ ๊ฐœ์„ , ๋กœ์ปฌ ์Šคํ† ๋ฆฌ์ง€ ๊ฒ€์ƒ‰์–ด ์ €์žฅ ๊ธฐ๋Šฅ ๊ฐœ์„ 

๐Ÿ“Œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ๋กœ์ปฌ ์Šคํ† ๋ฆฌ์ง€ ๋กœ์ง์„ hook์œผ๋กœ ๊ฐ์ž ํ˜ธ์ถœํ•ด์„œ ์ƒ๊ฒผ๋˜ ์ด์Šˆ ํ•ด๊ฒฐ
  • ๊ณก ๋””์ž์ธ ๊ฐœ์„ 

๐Ÿ’ฌ ์ถ”๊ฐ€ ์ฐธ๊ณ  ์‚ฌํ•ญ

@GulSam00 GulSam00 requested a review from Copilot February 2, 2026 16:14
@vercel
Copy link
Contributor

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
singcode Error Error Feb 2, 2026 4:25pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

์ด PR์€ ๊ฒ€์ƒ‰ ๊ธฐ๋Šฅ์˜ UX/UI ๊ฐœ์„ ๊ณผ ๋กœ์ปฌ ์Šคํ† ๋ฆฌ์ง€ ๊ด€๋ฆฌ ๋ฐฉ์‹์„ ๊ฐœ์„ ํ•ฉ๋‹ˆ๋‹ค. ๊ธฐ์กด์— ๊ฐ ์ปดํฌ๋„ŒํŠธ์—์„œ ๋…๋ฆฝ์ ์œผ๋กœ ๋กœ์ปฌ ์Šคํ† ๋ฆฌ์ง€๋ฅผ ๊ด€๋ฆฌํ•˜๋˜ ๋ฐฉ์‹์—์„œ Zustand๋ฅผ ํ™œ์šฉํ•œ ์ค‘์•™ ์ง‘์ค‘์‹ ์ƒํƒœ ๊ด€๋ฆฌ๋กœ ์ „ํ™˜ํ•˜์—ฌ ์ผ๊ด€์„ฑ ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes:

  • ๊ฒ€์ƒ‰ ํžˆ์Šคํ† ๋ฆฌ๋ฅผ ๊ด€๋ฆฌํ•˜๋Š” ์ปค์Šคํ…€ ํ›…(useSearchHistory)์„ Zustand store(useSearchHistoryStore)๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜
  • ๊ฒ€์ƒ‰ ๊ฒฐ๊ณผ ์นด๋“œ UI ๋””์ž์ธ ๊ฐœ์„  ๋ฐ ์•„ํ‹ฐ์ŠคํŠธ ํด๋ฆญ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋‹ค๋ฅธ store๋“ค์˜ initialState ํŒจํ„ด ํ†ต์ผ

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/web/src/stores/useSearchHistoryStore.ts localStorage ๊ธฐ๋ฐ˜ ๊ฒ€์ƒ‰ ํžˆ์Šคํ† ๋ฆฌ๋ฅผ Zustand persist ๋ฏธ๋“ค์›จ์–ด๋กœ ๊ตฌํ˜„ํ•œ ์ƒˆ๋กœ์šด store ์ถ”๊ฐ€
apps/web/src/stores/useModalStore.ts initialState ํŒจํ„ด ์ ์šฉ ๋ฐ closeMessage ์‹œ ์ดˆ๊ธฐ ์ƒํƒœ๋กœ ์™„์ „ํžˆ ๋ฆฌ์…‹ํ•˜๋„๋ก ๊ฐœ์„ 
apps/web/src/stores/useAuthStore.ts initialState ํŒจํ„ด ์ ์šฉ ๋ฐ logout ์‹œ ์ดˆ๊ธฐ ์ƒํƒœ๋กœ ์™„์ „ํžˆ ๋ฆฌ์…‹ํ•˜๋„๋ก ๊ฐœ์„ 
apps/web/src/hooks/useSearchSong.ts useSearchHistory hook์—์„œ useSearchHistoryStore๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜
apps/web/src/hooks/useSearchHistory.ts Zustand store๋กœ ๋Œ€์ฒด๋˜์–ด ์‚ญ์ œ๋จ
apps/web/src/app/search/SearchResultCard.tsx ์นด๋“œ ๋ ˆ์ด์•„์›ƒ ๊ฐœ์„ , absolute ํฌ์ง€์…”๋‹ ์ œ๊ฑฐ, ์•„ํ‹ฐ์ŠคํŠธ ํด๋ฆญ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
apps/web/src/app/search/HomePage.tsx ScrollArea๋ฅผ ์ผ๋ฐ˜ div๋กœ ๋ณ€๊ฒฝ, useEffect ์œ„์น˜ ์ด๋™, ์•„ํ‹ฐ์ŠคํŠธ ํด๋ฆญ ํ•ธ๋“ค๋Ÿฌ ์ถ”๊ฐ€
apps/web/public/changelog.json ๋ฒ„์ „ 2.0.1 ๋ณ€๊ฒฝ์‚ฌํ•ญ ์ถ”๊ฐ€
apps/web/package.json ๋ฒ„์ „์„ 1.9.1์—์„œ 2.0.1๋กœ ์—…๋ฐ์ดํŠธ
apps/web/GEMINI.md ์›น ์•ฑ์˜ ๊ธฐ์ˆ  ์Šคํƒ ๋ฐ ์ปจ๋ฒค์…˜ ๋ฌธ์„œ ์ถ”๊ฐ€
GEMINI.md ํ”„๋กœ์ ํŠธ ์ „์ฒด ๊ตฌ์กฐ ๋ฐ ๊ธฐ์ˆ  ์Šคํƒ ๋ฌธ์„œ ์ถ”๊ฐ€
.gitignore temp/ ๋””๋ ‰ํ† ๋ฆฌ ์ถ”๊ฐ€

)}
</div>
<ScrollArea className="h-[calc(100vh-24rem)]">
<div className="h-[calc(100vh-24rem)] overflow-x-hidden overflow-y-auto">
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScrollArea๋ฅผ ์ผ๋ฐ˜ div๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค. ํ”„๋กœ์ ํŠธ ์ „๋ฐ˜์—์„œ ScrollArea ์ปดํฌ๋„ŒํŠธ๋ฅผ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ๋Š” ํŒจํ„ด(apps/web/src/app/info/like/page.tsx:46, apps/web/src/app/info/save/page.tsx:194, apps/web/src/app/popular/page.tsx:22, apps/web/src/app/tosing/page.tsx:29)๊ณผ ์ผ๊ด€์„ฑ์ด ๋–จ์–ด์ง‘๋‹ˆ๋‹ค. ํŠน๋ณ„ํ•œ ์ด์œ ๊ฐ€ ์—†๋‹ค๋ฉด ScrollArea ์ปดํฌ๋„ŒํŠธ๋ฅผ ๊ณ„์† ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค.

Copilot uses AI. Check for mistakes.
Comment on lines +50 to +55
<span
className="text-muted-foreground cursor-pointer truncate text-sm hover:underline"
onClick={onClickArtist}
>
{artist}
</span>
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ฐ€์ˆ˜๋ช…์„ ํด๋ฆญํ•  ์ˆ˜ ์žˆ๋Š” ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. button ๋˜๋Š” role="button"์„ ์‚ฌ์šฉํ•˜๊ณ  ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ(onKeyDown ๋˜๋Š” onKeyPress)์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค. ํ˜„์žฌ๋Š” ๋งˆ์šฐ์Šค ํด๋ฆญ๋งŒ ๊ฐ€๋Šฅํ•˜์—ฌ ํ‚ค๋ณด๋“œ ์‚ฌ์šฉ์ž๊ฐ€ ์ด ๊ธฐ๋Šฅ์„ ์‚ฌ์šฉํ•  ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค.

Copilot uses AI. Check for mistakes.
}

if (parsedSearch) {
console.log('parsedSearch ', parsedSearch);
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋””๋ฒ„๊น…์šฉ console.log๊ฐ€ ๋‚จ์•„์žˆ์Šต๋‹ˆ๋‹ค. ํ”„๋กœ๋•์…˜ ์ฝ”๋“œ์—์„œ๋Š” ์ œ๊ฑฐํ•ด์ฃผ์„ธ์š”.

Suggested change
console.log('parsedSearch ', parsedSearch);

Copilot uses AI. Check for mistakes.
searchHistory: [] as string[],
};

export const useSearchHistoryStore = create(
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useSearchHistoryStore๋Š” ๋‹ค๋ฅธ store๋“ค(useAuthStore, useModalStore)๊ณผ ๋‹ฌ๋ฆฌ default export๊ฐ€ ์•„๋‹Œ named export๋กœ ๋˜์–ด์žˆ์Šต๋‹ˆ๋‹ค. ์ฝ”๋“œ๋ฒ ์ด์Šค์˜ ์ผ๊ด€์„ฑ์„ ์œ„ํ•ด 'export default useSearchHistoryStore'๋กœ ๋ณ€๊ฒฝํ•˜๋Š” ๊ฒƒ์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค. ๋‹ค๋ฅธ store ํŒŒ์ผ๋“ค(useAuthStore.ts:264, useModalStore.ts:56)์„ ์ฐธ๊ณ ํ•ด์ฃผ์„ธ์š”.

Copilot uses AI. Check for mistakes.
@GulSam00 GulSam00 merged commit 1e295f4 into develop Feb 2, 2026
1 of 2 checks passed
@GulSam00 GulSam00 deleted the feat/modifyUIUX branch February 2, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant