-
Notifications
You must be signed in to change notification settings - Fork 0
Chore : 버전 2.3.0 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Chore : 버전 2.3.0 #153
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
80b28f6
Update README.md
GulSam00 a169b8c
feat : MarqueeText 자동 스크롤 텍스트 적용
GulSam00 84ccba8
fix : 버튼 눌러서 isExpanded 넓히는 방식으로 수정
GulSam00 242a3e1
fix : SongCard css 수정
GulSam00 70459a4
feat : 추천 정보 검색 시 조회 가능. 곡 추천 시 UI 개선
GulSam00 20cabc6
feat : 랭킹 페이지에서 추천 기능 추가
GulSam00 11acbf9
feat : 랭킹 페이지 UI 조정
GulSam00 693c283
chore : 버전 2.3.0
GulSam00 fc2e00d
Update README.md
GulSam00 8c3fc54
hotfix : 빌드 에러 수정. thumb 필드 옵셔널 타입 조정.
GulSam00 0f8f405
Merge branch 'feat/scrollText' of https://github.com/GulSam00/sing-co…
GulSam00 fa75ed2
fix : 달에 맞게 날짜 조정
GulSam00 f062777
Merge pull request #150 from GulSam00/feat/scrollText
GulSam00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "web", | ||
| "version": "2.2.0", | ||
| "version": "2.3.0", | ||
| "type": "module", | ||
| "private": true, | ||
| "scripts": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:news="http://www.google.com/schemas/sitemap-news/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:mobile="http://www.google.com/schemas/sitemap-mobile/1.0" xmlns:image="http://www.google.com/schemas/sitemap-image/1.1" xmlns:video="http://www.google.com/schemas/sitemap-video/1.1"> | ||
| <url><loc>https://www.singcode.kr</loc><lastmod>2026-02-19T15:16:29.251Z</lastmod><changefreq>weekly</changefreq><priority>0.7</priority></url> | ||
| <url><loc>https://www.singcode.kr</loc><lastmod>2026-03-02T07:59:31.054Z</lastmod><changefreq>weekly</changefreq><priority>0.7</priority></url> | ||
| </urlset> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| 'use client'; | ||
|
|
||
| import { Construction } from 'lucide-react'; | ||
| // import IntervalProgress from '@/components/ui/IntervalProgress'; | ||
| import { RotateCw } from 'lucide-react'; | ||
|
|
||
| import RankingItem from '@/components/RankingItem'; | ||
| import StaticLoading from '@/components/StaticLoading'; | ||
| import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card'; | ||
| import { ScrollArea } from '@/components/ui/scroll-area'; | ||
| import { useSongThumbQuery } from '@/queries/songThumbQuery'; | ||
|
|
||
| export default function PopularRankingList() { | ||
|
|
@@ -17,27 +17,32 @@ export default function PopularRankingList() { | |
| } | ||
|
|
||
| return ( | ||
| <Card> | ||
| <Card className="relative"> | ||
| <CardHeader className="flex flex-row items-center justify-between space-y-0 pb-2"> | ||
| <CardTitle className="text-xl">추천 곡 순위</CardTitle> | ||
| {/* <IntervalProgress duration={5000} onComplete={() => refetch()} isLoading={isFetching} /> */} | ||
|
|
||
| <RotateCw onClick={() => refetch()} className="cursor-pointer hover:animate-spin" /> | ||
| <RotateCw | ||
| onClick={() => refetch()} | ||
| className="absolute top-6 right-6 cursor-pointer hover:animate-spin" | ||
| /> | ||
| </CardHeader> | ||
| <CardContent className="pt-0"> | ||
| <div className="space-y-0"> | ||
| {data && data.length > 0 ? ( | ||
| data.map((item, index) => ( | ||
| <RankingItem key={index} {...item} rank={index + 1} value={item.total_thumb} /> | ||
| )) | ||
| ) : ( | ||
| <div className="flex h-64 flex-col items-center justify-center gap-4"> | ||
| <Construction className="text-muted-foreground h-16 w-16" /> | ||
| <p className="text-muted-foreground text-xl">데이터를 준비중이에요</p> | ||
| </div> | ||
| )} | ||
| </div> | ||
| </CardContent> | ||
|
|
||
| <ScrollArea className="h-[calc(100vh-20rem)]"> | ||
| <CardContent className="pt-0"> | ||
| <div className="space-y-0"> | ||
| {data && data.length > 0 ? ( | ||
| data.map((item, index) => ( | ||
| <RankingItem key={index} {...item} rank={index + 1} value={item.total_thumb} /> | ||
| )) | ||
|
Comment on lines
+33
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2. Index key state bug Popular ranking items use key={index} while each RankingItem maintains local dialog open state;
when the list refetches and order changes, React can re-use components by index and attach the open
state to the wrong song. This can manifest as the wrong song opening in the recommendation modal
after refresh/reorder.
Agent Prompt
|
||
| ) : ( | ||
| <div className="flex h-64 flex-col items-center justify-center gap-4"> | ||
| <Construction className="text-muted-foreground h-16 w-16" /> | ||
| <p className="text-muted-foreground text-xl">데이터를 준비중이에요</p> | ||
| </div> | ||
| )} | ||
| </div> | ||
| </CardContent> | ||
| </ScrollArea> | ||
| </Card> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Validate recent-add params
🐞 Bug⛯ ReliabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools