Merged
Conversation
- /pr 커맨드: develop/main 브랜치에서 실행 시 차단 로직 추가 - /start 커맨드: 인자 없을 때 git diff 기반 자동 판단 - 워크플로우 사이클에 /pr 단계 추가 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- postTransDictionary.ts 및 transList.txt 삭제 - TransDictionary 타입, 관련 DB 함수, 로그 함수 제거 - trans 스크립트 제거, CLAUDE.md 반영 - ESLint v9 flat config 추가 및 lint 명령어 수정 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review Summary by QodoImprove workflow commands, remove translation feature, and add ESLint v9 config
WalkthroughsDescription• Improved /pr command safety by blocking execution on develop/main branches • Enhanced /start command to auto-detect work type from git diff when no arguments provided • Removed Japanese translation feature (postTransDictionary.ts and related code) • Added ESLint v9 flat config and updated documentation formatting • Updated workflow cycle to include /pr step in command documentation Diagramflowchart LR
A["Workflow Commands"] --> B["Enhanced /pr Safety"]
A --> C["Auto-detect /start"]
D["Code Cleanup"] --> E["Remove Translation"]
D --> F["Remove transList.txt"]
G["Tooling Updates"] --> H["ESLint v9 Config"]
G --> I["Update Documentation"]
B --> J["Updated Workflow"]
C --> J
File Changes1. .claude/commands/pr.md
|
Code Review by Qodo
1. Undeclared eslint-config import
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+1
to
+4
| import { config } from '@repo/eslint-config/base'; | ||
|
|
||
| /** @type {import("eslint").Linter.Config} */ | ||
| export default config; |
There was a problem hiding this comment.
1. Undeclared eslint-config import 🐞 Bug ⛯ Reliability
packages/crawling/eslint.config.mjs가 @repo/eslint-config/base를 import하지만 packages/crawling/package.json에 @repo/eslint-config가 선언되어 있지 않아, ESLint가 설정을 로드하는 단계에서 모듈 해석 실패로 pnpm lint가 깨질 수 있습니다.
Agent Prompt
## Issue description
`packages/crawling/eslint.config.mjs` imports `@repo/eslint-config/base` but `packages/crawling/package.json` does not declare `@repo/eslint-config`. This can break `pnpm lint` in `@repo/crawling` because ESLint can’t resolve the config module.
## Issue Context
- The shared config is exported via `@repo/eslint-config` subpath export `./base`.
- `@repo/crawling` must depend on `@repo/eslint-config` for pnpm to link it into that package’s resolution context.
## Fix Focus Areas
- packages/crawling/package.json[1-36]
- packages/crawling/eslint.config.mjs[1-4]
- packages/eslint-config/package.json[1-24]
## Suggested change
- Add `"@repo/eslint-config": "workspace:*"` to `devDependencies` of `packages/crawling/package.json`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 제목
[Type] : 작업 내용 요약
📌 변경 사항
💬 추가 참고 사항