Skip to content

Refactor/188 auto tag song pre fetch #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GulSam00 merged 2 commits into from
Apr 12, 2026
Merged

Refactor/188 auto tag song pre fetch #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0173523
refactor : autoTagSong JSON 좜λ ₯ ν˜•μ‹ ν”„λ‘¬ν”„νŠΈ λͺ…μ‹œ (#188)
GulSam00 Apr 12, 2026
e210066
chore : tagging 크둠 μŠ€μΌ€μ€„ μΌμ‹œ 정지 (#188)
GulSam00 Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tagging_song.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Tagging Songs

on:
schedule:
- cron: "0 10 * * *" # ν•œκ΅­ μ‹œκ°„ 19:00 μ‹€ν–‰ (UTC+9 β†’ UTC 10:00)
workflow_dispatch:
# on:
# schedule:
# - cron: "0 10 * * *" # ν•œκ΅­ μ‹œκ°„ 19:00 μ‹€ν–‰ (UTC+9 β†’ UTC 10:00)
# workflow_dispatch:
Comment on lines +3 to +6
Copy link
Copy Markdown

@qodo-code-review qodo-code-review Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Workflow triggers disabled 🐞 Bug ☼ Reliability

.github/workflows/tagging_song.yml has its entire on: section commented out, so the workflow
will not run on schedule and cannot be manually dispatched. This disables the automated song-tagging
pipeline that the repo documentation says should run daily and be manually runnable.
Agent Prompt 
## Issue description
The GitHub Actions workflow `.github/workflows/tagging_song.yml` has no triggers because the `on:` block (schedule + workflow_dispatch) is commented out. This prevents scheduled runs and manual dispatch, effectively disabling tagging automation.

## Issue Context
`packages/crawling/CLAUDE.md` documents that `tagging_song.yml` runs daily and supports manual dispatch.

## Fix Focus Areas
- .github/workflows/tagging_song.yml[1-7]
- packages/crawling/CLAUDE.md[120-130]

## Suggested fix
- Uncomment/restore the `on:` block with `schedule` and `workflow_dispatch`.
- If disabling is intentional, update `packages/crawling/CLAUDE.md` to reflect the new behavior and provide an alternative execution path.

β“˜ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


permissions:
contents: write # push κΆŒν•œμ„ μœ„ν•΄ ν•„μš”
Expand Down
7 changes: 7 additions & 0 deletions packages/crawling/src/utils/getSongTag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ export const autoTagSong = async (
- Language Slot (100-199): EXACTLY 1 tag.
- Genre Slot (200-299): EXACTLY 1 tag.
- Origin Slot (300-399): 1 to 2 tags, sorted by relevance.
- **Return the final result strictly in JSON format.**

[Output Instructions]
- **Combine all selected IDs into a single flat array.**
- **The final output must be a JSON object with a single key "tag_ids".**
- **Example: {"tag_ids":}**
- **Do not use keys like "language", "genre", or "origin" in the JSON.**

[Contextual Hints]
${languageHints}
Expand Down