Skip to content

chore: update coverage paths in configuration and workflows#15

Merged
Guria merged 1 commit into
mainfrom
var
May 28, 2026
Merged

chore: update coverage paths in configuration and workflows#15
Guria merged 1 commit into
mainfrom
var

Conversation

@Guria
Copy link
Copy Markdown
Owner

@Guria Guria commented May 28, 2026

Summary by CodeRabbit

  • Chores
    • Reorganized coverage report handling in the build workflow to use a new internal directory structure.
    • Updated cleanup task configuration to streamline removal of build artifacts.
    • Adjusted test coverage configuration for improved organization of generated reports.

Review Change Stack

Copilot AI review requested due to automatic review settings May 28, 2026 00:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 54a0bb63-f41e-41b0-850a-0b7b584fb0cc

📥 Commits

Reviewing files that changed from the base of the PR and between ad337b7 and 41ea64d.

📒 Files selected for processing (4)
  • .config/mise/conf.d/tasks-dev.toml
  • .github/workflows/test.yml
  • .gitignore
  • vitest.config.ts
💤 Files with no reviewable changes (1)
  • .gitignore

Walkthrough

Coverage output directory is relocated from coverage/ to .var/coverage/. Vitest configuration sets the reports directory, GitHub Actions workflow adjusts artifact upload and summary generation paths, cleanup removes the old directory from its target list, and gitignore stops tracking the original location.

Changes

Coverage output directory relocation

Layer / File(s) Summary
Coverage output directory configuration
vitest.config.ts, .github/workflows/test.yml, .config/mise/conf.d/tasks-dev.toml, .gitignore
Vitest directs coverage reports to .var/coverage, GitHub Actions workflow reads and writes reports from the new location with updated path checks, cleanup task stops removing the old coverage directory, and coverage is removed from gitignore.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Guria/modern-stack#2: Updates GitHub Actions coverage artifact handling; both PRs modify the test workflow's coverage paths and summary generation.
  • Guria/modern-stack#4: Modifies tasks.clean cleanup; this PR aligns cleanup by removing coverage from deletion targets as output moves to .var/coverage/.

Poem

📁 Coverage hops to .var/coverage/ deep,
Away from gitignore's cleanup sweep,
Vitest and Actions agree on the way,
Old cleanup rules fade away,
A cleaner nest for reports to keep! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating coverage paths from 'coverage' to '.var/coverage' across configuration files and workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch var

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Fallow audit report

No GitHub PR/MR findings.

Generated by fallow.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41ea64d00f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/test.yml
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves Vitest coverage output into the existing .var/ transient artifacts area and updates related workflow and cleanup configuration accordingly.

Changes:

  • Configures Vitest coverage reports to write to .var/coverage.
  • Updates CI artifact upload and coverage-summary generation to read from the new path.
  • Removes obsolete top-level coverage ignore/cleanup entries now covered by .var.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
vitest.config.ts Sets coverage report output directory to .var/coverage.
.github/workflows/test.yml Updates coverage artifact and summary paths for CI.
.gitignore Removes obsolete top-level coverage ignore entry.
.config/mise/conf.d/tasks-dev.toml Simplifies clean task because .var now contains coverage output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Guria Guria merged commit 3d0d678 into main May 28, 2026
3 checks passed
@Guria Guria deleted the var branch May 28, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants