feat(e2e): employee domain — scenarios + spec rewrites

[jeffredodd]

Summary

• Add employee-onboarding and employee-self-onboarding scenarios
• Rewrite employee spec files to use scenario fixture
• Move to e2e/tests/employee/ directory

canary-01-admin-onboarding-PASSED.webm

canary-02-self-onboarding-PASSED.webm

canary-03-termination-PASSED.webm

Base: PR #1829 (e2e/infrastructure)

Notion tasks: #68-073

Made with Cursor

[jeffredodd]

@cursoragent can you resolve conflicts here and make sure we're rebased off main?

[cursor]

Summary

Successfully resolved all conflicts and rebased the e2e/employee-domain branch onto main. The branch now contains 25 commits cleanly applied on top of main.

What I did:

• Rebased 35 commits from the branch onto the latest main
• Resolved numerous merge conflicts in:
  • package.json (scenario scripts)
  • e2e/scenario/loader.test.ts (test implementation approach)
  • .github/workflows/ci.yaml (CI infrastructure evolution)
  • e2e/scenario/runner.ts, e2e/scenario/scripts.ts (scenario infrastructure)
  • e2e/utils/localTestFixture.ts (E2E_USE_REAL_BACKEND vs E2E_LOCAL)
  • e2e/utils/helpers.ts (case-insensitive regex matchers)
• Kept HEAD's more complete versions where main had already evolved beyond the branch's incremental changes (e.g., CI domain sharding, e2e-setup infrastructure)
• Force-pushed the rebased branch to origin

The PR is now up-to-date with main and ready for review. All conflicts have been resolved while preserving both the branch's employee domain work and main's infrastructure improvements.

  

[serikjensen]

Claude recs:

1. Incomplete migration in employee-onboarding.spec.ts

The file was moved and given a beforeEach scenario annotation, but the tests still navigate with companyId=123 and don't consume the scenario fixture. Every other new spec in this PR drops the hardcoded ID. This will fail in CI's domain-matrix mode where companyId=123 isn't a real company.

// Fix: convert to scenario pattern, matching the new spec files:
test('completes the happy path successfully', async ({ page, scenario }) => {
  test.skip(!scenario.flowToken, 'Requires scenario provisioning')
  await page.goto('/?flow=employee-onboarding')
  // ... rest of test
})

2. Unsafe type cast in pickTerminationCandidateId (employeeFlowDrivers.ts:998)

r.json() is cast directly with as EmployeeSummary[] on a live API response. If the endpoint returns an unexpected shape or a non-array (e.g., a paginated { employees: [...] } wrapper), the .find() call silently returns undefined on every attempt, the polling loop exhausts, and termination is skipped with a misleading error.

// Fix: guard the array assumption at runtime
const data: unknown = r.ok ? await r.json() : []
const employees: EmployeeSummary[] = Array.isArray(data) ? (data as EmployeeSummary[]) : []

3. Silent pass in employee-self-onboarding.spec.ts (lines 609–623)

Same pattern flagged in #1833: the test returns early with a green result if any "completed" text appears after a single Continue click, and the fallback heading | Continue button assertion would pass on virtually any loaded page. The full multi-step flow is never verified.

// Fix: remove the early-return branch; assert the specific completion heading:
await expect(
  page.getByRole('heading', { name: /completed|that's it/i }),
).toBeVisible({ timeout: 60_000 })

---

Posted by Claude on behalf of Steve

[jeffredodd]

@cursoragent Can you investigate the feedback and see if we should address Steve's cursor feedback?

[cursor]

Excellent! I've investigated and addressed all three issues from Steve's feedback. Here's what I fixed:

✅ All Issues Resolved

1. employee-onboarding.spec.ts - Incomplete migration

• Problem: Test used hardcoded companyId=123 instead of consuming the scenario fixture
• Fix: Now uses scenario fixture and includes test.skip guard for CI compatibility
• Impact: Test will now work properly in CI's domain-matrix mode

2. pickTerminationCandidateId - Unsafe type cast

• Problem: Direct cast as EmployeeSummary[] without runtime validation could cause silent failures
• Fix: Added runtime array validation before casting:

  const data: unknown = await fetch(...).then(r => r.ok ? r.json() : [])
  const employees: EmployeeSummary[] = Array.isArray(data) ? (data as EmployeeSummary[]) : []

• Impact: Prevents silent failures if API returns unexpected shape

3. employee-self-onboarding.spec.ts - Silent pass

• Problem: Early return allowed test to pass after single Continue click without verifying full flow
• Fix: Removed early-return branch and now directly asserts completion heading with 60s timeout
• Impact: Test now properly verifies the complete onboarding flow

All fixes have been committed and pushed to the branch. The PR is ready for review with these improvements applied.

  

[jeffredodd]

@cursoragent can you resolve the conflicts

[cursor]

Perfect! I've successfully resolved all conflicts and rebased the branch onto the latest main.

Summary

✅ Conflicts Resolved and Rebased

What I did:

• Rebased the e2e/employee-domain branch onto the latest main (which advanced from 83932d20 to 686e2c96)
• Resolved merge conflicts in:
  • e2e/utils/localTestFixture.ts (kept HEAD's advanced worker-scoped caching implementation with timing annotations)
  • e2e/utils/helpers.ts (merged improved comment documentation)
• Force-pushed the rebased branch to origin

Current state:

• Branch is now 28 commits ahead of main
• All conflicts resolved
• Clean working tree
• Ready for CI to run on the latest codebase

The branch now includes all the latest changes from main, including:

• Payroll domain E2E work (feat: payroll domain — scenarios + spec rewrites #1830)
• Dashboard compensation features (feat(Dashboard): pending compensation change alerts on compensation card #1886, feat(Dashboard): route compensation flow through DashboardFlow state machine #1880)
• Client pagination hook (feat: add useClientPagination hook for in-memory list pagination #1885)
• Time-off domain E2E work (feat(e2e): time-off domain — scenario + spec rewrite #1834)

CI will now test your employee domain E2E changes against the most recent main branch.