Extend host info with OVMF package#932
Conversation
There was a problem hiding this comment.
Pull request overview
Extends QemuHCK host/system reporting to include firmware (OVMF) package info alongside existing QEMU/swtpm details.
Changes:
- Change
hypervisor_dependencies_package_infoto return structured package info entries and add OVMF package reporting when UEFI firmware is configured. - Update host info logging to print “System information” first and then append dependency package lines.
- Expose QemuMachine firmware config via
attr_reader :fwand update HCKTest system-info collection to consume the structured dependency info.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/setupmanagers/qemuhck/qemuhck.rb | Returns structured dependency package info and logs OVMF package when present. |
| lib/setupmanagers/qemuhck/qemu_machine.rb | Exposes firmware config (fw) for package introspection/logging. |
| lib/engines/hcktest/tests.rb | Records host info and iterates structured dependency package info into the report payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request refactors the hypervisor dependency reporting system to support multiple components, specifically adding OVMF package information alongside swtpm. It updates the data structures to use arrays of hashes for better extensibility and modifies the logging and system info methods accordingly. A critical feedback point highlights a potential NoMethodError when retrieving the firmware binary path from an empty hash, recommending a safer check and more idiomatic Ruby usage.
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
No description provided.