Skip to content

Extend host info with OVMF package#932

Merged
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:host-info
Apr 27, 2026
Merged

Extend host info with OVMF package#932
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:host-info

Conversation

@kostyanf14
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 27, 2026 12:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends QemuHCK host/system reporting to include firmware (OVMF) package info alongside existing QEMU/swtpm details.

Changes:

  • Change hypervisor_dependencies_package_info to return structured package info entries and add OVMF package reporting when UEFI firmware is configured.
  • Update host info logging to print “System information” first and then append dependency package lines.
  • Expose QemuMachine firmware config via attr_reader :fw and update HCKTest system-info collection to consume the structured dependency info.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
lib/setupmanagers/qemuhck/qemuhck.rb Returns structured dependency package info and logs OVMF package when present.
lib/setupmanagers/qemuhck/qemu_machine.rb Exposes firmware config (fw) for package introspection/logging.
lib/engines/hcktest/tests.rb Records host info and iterates structured dependency package info into the report payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/setupmanagers/qemuhck/qemuhck.rb
Comment thread lib/setupmanagers/qemuhck/qemuhck.rb Outdated
Comment thread lib/engines/hcktest/tests.rb
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the hypervisor dependency reporting system to support multiple components, specifically adding OVMF package information alongside swtpm. It updates the data structures to use arrays of hashes for better extensibility and modifies the logging and system info methods accordingly. A critical feedback point highlights a potential NoMethodError when retrieving the firmware binary path from an empty hash, recommending a safer check and more idiomatic Ruby usage.

Comment thread lib/setupmanagers/qemuhck/qemuhck.rb Outdated
Comment thread lib/setupmanagers/qemuhck/qemuhck.rb Fixed
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
@kostyanf14 kostyanf14 merged commit 7e75e84 into HCK-CI:master Apr 27, 2026
9 checks passed
@kostyanf14 kostyanf14 deleted the host-info branch April 27, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants